Skip to content

Commit

Permalink
Refactor/build-src-cleanup (#111)
Browse files Browse the repository at this point in the history
* Remove deprecated items and refactor buildSrc
* Delete CHANGELOG.md
Changelog will be auto generated in releases
  • Loading branch information
wax911 committed Jun 16, 2023
1 parent accf150 commit e419a20
Show file tree
Hide file tree
Showing 25 changed files with 194 additions and 246 deletions.
6 changes: 6 additions & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# These are supported funding model platforms

github: [wax911]
patreon: wax911
ko_fi: anitrend
issuehunt: anitrend
47 changes: 13 additions & 34 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,51 +1,30 @@
---
name: Bug Report
about: Report any issues regarding the project and help us identify bugs quicker

about: Create a bug report to help us identify bugs faster and improve the application
labels: ["bug"]
---

# Issue Guidelines
# AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/master/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.
Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/develop/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.

**You may find an answer in already closed issues**:
https://github.com/AniTrend/android-emojify/issues?q=is%3Aissue+is%3Aclosed

## Description of Bug
<!-- A clear and concise short description of what the bug is. Remember to include the library version if the bug is specific to a release -->

## Description Of Bug
<!--- A clear and concise description of what the bug is. -->

__Media Detail Pages__ with long titles are under the __Overview Tab__ are cropped from start instead of from the end.

**Steps To Reproduce**
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error


## Expected Behaviour
<!--- A clear and concise description of what you expect to happen. -->

Perhaps it would be best if anime/manga titles are not truncated
## Reproduction Steps
<!-- In detail, please explain how and what can be done to reproduce this bug. -->


## Screenshots/Videos
<!--- If applicable, add screenshots to help explain your problem. If none of these are available please remove this section alone -->


## Device & Build Information
<!--- Please provide any relevant information about your device. This is important in case the issue is not reproducible except for under certain conditions. -->

* OS Version: Lollipop 5.0.1
* App Version: 1.2.0
* Phone Model: Xperia SP
* Phone Brand: Sony
<!-- Screenshots or videos usually paint a better picture, if you have non please remove this heading -->


## Additional Context
<!--- What are you trying to accomplish? Providing context helps us come up with a solution that is most useful in the real world, also include an logs if you have any in this section -->

I have tested with multiple devices and the issue doesn't seem to be bound to any specific device, OS version or form factor.

I have tested with ......
<!--
Providing context helps us come up with a solution that is most useful in the real world,
also include any logs if you have any in this section, if not please remove this section
-->
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: 🗣 Ask a Question, Discuss
url: https://github.com/anitrend/android-emojify/discussions
about: General discussion, suggest ideas, share concepts or resources or ask questions, like "How does this work 🤔?"
- name: 🤗 Support the organisation
url: https://patreon.com/wax911
about: Support the AniTrend financially.
29 changes: 14 additions & 15 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,30 @@
---
name: Feature Request
about: Got a suggestion? Then this is what you should use

about: Suggest an idea or feature for this project
labels: ["feature request"]
---

# Issue Guidelines
# AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/master/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.
Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/develop/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.

**You may find an answer in already closed issues**:
https://github.com/AniTrend/android-emojify/issues?q=is%3Aissue+is%3Aclosed


## Feature Information
<!-- Is your feature request related to a problem? Please describe. -->

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
<!-- Is your feature request related to a problem? Please describe and be concise. -->


## Solution Information
<!-- Describe the solution you'd like -->

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
<!--
If you have any ideas regarding the creation of the feature please list them here,
and if not please remove this section
-->


## Additional context
Add any other context or screenshots about the feature request here.
## Additional Context
<!--
Any other information you might want to share, or that doesn't fit into any of the above headings.
If not please remove this section
-->
9 changes: 5 additions & 4 deletions .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
---
name: Question
about: Ask any general question regarding the project, also if you use this if you don't know what category to use

about: Ask any general question regarding the project or application
labels: ["question"]
---

# Issue Guidelines
# AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/master/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.
Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/AniTrend/android-emojify/blob/develop/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.

**You may find an answer in already closed issues**:
https://github.com/AniTrend/android-emojify/issues?q=is%3Aissue+is%3Aclosed

## Question
<!-- Clearly and explicitly explain the details about your question -->

I would like to know if... I have also searched in the closed issues and...

## Additional Context
Expand Down
40 changes: 13 additions & 27 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,46 +1,32 @@
# Pull Request Template
# AniTrend Pull Request

Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/AniTrend/android-emojify/blob/master/CONTRIBUTING.md)
Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/AniTrend/android-emojify/blob/develop/CONTRIBUTING.md)
to make the process easy and effective for everyone involved.

**Please open an issue** before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
Before opening a pull request, please ensure you've done the following:
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] You have followed our [**contributing guidelines**](https://github.com/AniTrend/android-emojify/blob/master/CONTRIBUTING.md)
- [ ] double-check your branch is based on `develop` and targets `develop`
- [ ] Pull request has tests
- [ ] Code is well-commented, linted and follows project conventions
- [ ] Documentation is updated (if necessary)
- [ ] Description explains the issue/use-case resolved
- [ ] I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)
- You have followed our [**contributing guidelines**](https://github.com/AniTrend/android-emojify/blob/develop/CONTRIBUTING.md)
- Double checked that your branch is based on `develop` and targets `develop` (where applicable)
- Pull request has tests (if applicable)
- Documentation is updated (if necessary)
- Description explains the issue/use-case resolved


## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):
<!--- Describe your changes in detail, or link an existing issue here -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue) or updated unit tests
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Enhancement (Improves existing functionality)

<!--- Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) -->
<!--- Be kind to code reviewers, and please try to keep pull requests as small and focused as possible :) -->

**IMPORTANT**: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the [MIT License](https://github.com/AniTrend/android-emojify/blob/master/LICENSE.md).
owners to license your work under the terms of the [Apache License 2.0](https://github.com/AniTrend/android-emojify/blob/develop/LICENSE.md).
22 changes: 15 additions & 7 deletions .github/release-drafter.yml → .github/release-drafter-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,29 @@ categories:
- 'enhancement'
- title: '🐛 Bug Fixes'
labels:
- 'bugfix'
- 'hotfix'
- 'bug fix'
- title: '🧰 Maintenance'
labels:
- 'refactor'
- ':hammer_and_wrench: refactor'
- ':dagger: dependencies'
autolabeler:
- label: 'refactor'
- label: ':books: docs'
files:
- '*.md'
branch:
- '/docs{0,1}\/.+/'
- label: 'bugfix'
- label: 'bug fix'
branch:
- '/bugfix\/.+/'
- '/hotfix\/.+/'
title:
- '/fix/i'
- label: 'enhancement'
- label: 'feature'
branch:
- '/feature\/.+/'
- label: 'enhancement'
branch:
- '/enhancement\/.+/'
- label: 'dependencies'
branch:
- '/dependencies\/.+/'
Expand All @@ -40,10 +43,15 @@ version-resolver:
minor:
labels:
- 'minor'
- 'enhancement'
- 'feature'
patch:
labels:
- 'patch'
default: patch
- 'bugfix'
- 'hotfix'
- 'dependencies'
- 'refactor'
template: |
## What’s Changed
Expand Down
File renamed without changes.
10 changes: 4 additions & 6 deletions .github/workflows/android-spotless.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: gradle-lint-check
name: android-spotless

on:
push:
Expand All @@ -8,16 +8,14 @@ on:
- develop

jobs:
build:

spotless:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'adopt'

- name: Grant execute permission for gradlew
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/android-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,28 @@ on:
push:
branches: [ develop ]
pull_request:
branches:
- develop
paths-ignore:
- "app/src/main/**"

jobs:
build:
unit-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: gradle/wrapper-validation-action@v1
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'adopt'
- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Run tests
run: ./gradlew emojify:test --stacktrace

android:
instrumented-test:
runs-on: macos-latest
strategy:
fail-fast: false
Expand All @@ -38,7 +40,7 @@ jobs:
- uses: gradle/wrapper-validation-action@v1
- uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'adopt'
- uses: gradle/gradle-build-action@v2
- name: Run Tests
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/gradle-dokka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@ on:
branches: [ develop ]

jobs:
build:

generate-and-deploy-docs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'adopt'

- name: Grant execute permission for gradlew
Expand Down
22 changes: 0 additions & 22 deletions .github/workflows/release-builder.yml

This file was deleted.

11 changes: 10 additions & 1 deletion .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,20 @@ on:
push:
branches:
- 'develop'
pull_request:
# Only following types are handled by the action, but one can default to all as well
types: [opened, reopened, synchronize]

permissions:
contents: read

jobs:
update_draft_release:
update-draft-release:
runs-on: ubuntu-latest
steps:
- uses: release-drafter/release-drafter@v5
with:
config-name: release-drafter-config.yml
disable-autolabeler: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading

0 comments on commit e419a20

Please sign in to comment.