-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom serializer #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Thank you for this PR :) Please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
There is also a possiblity of non-breaking change for user who use the EmojiInitializer. Inside the lib AndroidManifest: <provider
android:name="androidx.startup.InitializationProvider"
android:authorities="${applicationId}.androidx-startup"
android:exported="false"
tools:node="merge">
<meta-data
android:name="io.wax911.emojify.initializer.EmojiInitializer"
android:value="androidx.startup" />
</provider> If user is using custom Deserializer <provider
android:name="androidx.startup.InitializationProvider"
android:authorities="${applicationId}.androidx-startup"
android:exported="false"
tools:node="merge">
<meta-data
android:name="com.package.CustomEmojiInitializer"
android:value="androidx.startup" />
<meta-data
android:name="io.wax911.emojify.initializer.EmojiInitializer"
android:value="androidx.startup"
tools:node="remove" />
</provider> |
chores: downgrade version to 1.8.0 as change is no longer breaking + adding readme
Please run |
Sure ! It is done :) I've noticed that you've tagged this changed as breaking but it is not |
Oh, I had seen this #178 (comment) thus the breaking status |
Yes at first it was a breaking change, but I've refacto the code in order to change it as non-breaking. I've explained in this comment |
The PR looks solid, I just have one concern though, since the property annotation on the Model class are for |
I have made a couple test with MoshiDeserializer (I have made a CustomDeserializer in the app example so users could experiment with it) and even though there was no Moshi annotation on the |
So I've added implementation for Jackson and Gson and they do work fine without the need to expose the Model. |
Perfect, this is amazing! Could we just rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved automated PR
Hello ! I'm back with bad news :'( |
Description
PR is related to issue: #178
Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of
the Apache License 2.0.