Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(breaking): compose platform migration #600

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

wax911
Copy link
Member

@wax911 wax911 commented Apr 30, 2024

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure you've done the following:

  • You have followed our contributing guidelines
  • Double checked that your branch is based on develop and targets develop (where applicable)
  • Pull request has tests (if applicable)
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved

Description

A lot of ground work for compose, phasing out view based screens and components

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the GPL v3 License.

@github-actions github-actions bot added the 🛠️ refactor House cleaning label Apr 30, 2024
@wax911 wax911 added the 🌵 breaking Breaking change that may not be backwards compatible label Apr 30, 2024
@wax911 wax911 changed the title refactor: compose platform migration refactor(breaking): compose platform migration Apr 30, 2024
@wax911 wax911 force-pushed the refactor/compose-platform-migration branch 3 times, most recently from de8aa5f to ae2a320 Compare May 5, 2024 10:14
@wax911 wax911 force-pushed the refactor/compose-platform-migration branch from ae2a320 to 6736f27 Compare June 9, 2024 14:33
@wax911 wax911 force-pushed the refactor/compose-platform-migration branch from 6736f27 to e39cd67 Compare June 20, 2024 20:17
- Wraps compact item recycler in compose android view
- Adds new custom platform preview  method
- Add dark theme preview parameter provider for non-annotation usecases
- Split out components to individual files
- Provide preview wrapper for surface wrapping via exposed prop
- Update tag composition to include general spoilers and media spoilers
@wax911 wax911 force-pushed the refactor/compose-platform-migration branch from e39cd67 to 2c38cdd Compare July 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌵 breaking Breaking change that may not be backwards compatible 🛠️ refactor House cleaning
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant