Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain Reading lists #15

Merged
merged 10 commits into from
Jul 26, 2020
Merged

Maintain Reading lists #15

merged 10 commits into from
Jul 26, 2020

Conversation

Akshat-Goyal
Copy link
Collaborator

  1. On clicking 'add to reading list' in search page, book is added to reading list, which is stored locally using shared preferences.
  2. All books are shown on the reading goal page, option to remove books from reading list is added.

@Akshat-Goyal
Copy link
Collaborator Author

One issue found, if same book is added on two different days, it is shown two times because of different date.

@GaurangTandon
Copy link
Collaborator

GaurangTandon commented Jul 25, 2020 •
edited
Loading

I'm reviewing and working on some additional stuff:

  1. Show toast notification when book added to reading list.
  2. Should save UID of book instead of its name, UID should be the primary key in our db.

@AnimeshSinha1309 AnimeshSinha1309 changed the title App/readinglist Maintain Reading lists Jul 25, 2020
@AnimeshSinha1309 AnimeshSinha1309 added the segment:ux All frontend development label Jul 25, 2020
@AnimeshSinha1309 AnimeshSinha1309 added this to the Early Preview Run milestone Jul 25, 2020
@AnimeshSinha1309 AnimeshSinha1309 added the type:feature New feature or request label Jul 25, 2020
@GaurangTandon GaurangTandon mentioned this pull request Jul 26, 2020
Closed
GaurangTandon
GaurangTandon approved these changes Jul 26, 2020
View reviewed changes
Copy link
Collaborator

@GaurangTandon GaurangTandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! But still the UID part is pending. #18

@GaurangTandon GaurangTandon merged commit d1374d6 into master Jul 26, 2020
@GaurangTandon GaurangTandon deleted the app/readinglist branch July 26, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaurangTandon GaurangTandon GaurangTandon approved these changes

@KanishAnand KanishAnand Awaiting requested review from KanishAnand

@avani17101 avani17101 Awaiting requested review from avani17101

Assignees

@GaurangTandon GaurangTandon

Labels
segment:ux All frontend development type:feature New feature or request
Projects
None yet
Milestone
Early Preview Run
Development

Successfully merging this pull request may close these issues.
3 participants
@Akshat-Goyal @GaurangTandon @AnimeshSinha1309