Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add voices #141 #23 #156

Merged
merged 2 commits into from
Jun 25, 2018
Merged

add voices #141 #23 #156

merged 2 commits into from
Jun 25, 2018

Conversation

vikasgola
Copy link
Contributor

Added a drop-down menu to select the voices.

Thanks for contributing. Your contribution might help someone understand the concepts better.

However, to make sure things are working properly, here's a checklist. Just make sure you check them.

closed_menu
open_menu

@vikasgola vikasgola changed the title add voices #141 add voices #141 #23 Jun 25, 2018
@gauthamzz
Copy link
Member

gauthamzz commented Jun 25, 2018

This is awesome 😎
I love it ❤️

Could you just reduce the text box size and font size,it looks a bit too big.

@vikasgola
Copy link
Contributor Author

Ok sure However in my opinion that's ok...

@gauthamzz
Copy link
Member

Yes

But i'm not a big fan of this
deepinscreenshot_select-area_20180625142006

Plus users only change voice once or twice. They shouldnt have to see things that they dont use very often. So a lesser size would work .

@vikasgola
Copy link
Contributor Author

@gauthamzz I decreased the font-size but that doesn't work. So, I changed the css to overflow-y: hidden that worked.

with small text and simple box
anna_2

with css overflow property
anna_1

@gauthamzz
Copy link
Member

yeah that works.

so you cant make the text box smaller, its fine . we can do that as another issue

@vikasgola
Copy link
Contributor Author

@gauthamzz completed.

@gauthamzz
Copy link
Member

Great work, thanks 👍

@gauthamzz gauthamzz merged commit f103aa9 into Anna-Assistant:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants