Avoid captcha challenges #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHA1 ciphers seem to be provoking cloudflare captcha challenges. By removing cipher AES128-SHA captchas can be avoided.
Closed
ghost
reviewed
May 13, 2019
ghost
reviewed
May 13, 2019
ghost
reviewed
May 13, 2019
Cookie domain has to start with a . otherwise the cookie won’t be properly detected.
- Always mount the adapter but only update ciphers if explicitly enabled. - Remove ECDHE+SHA instead of AES128-SHA since TLSv1.0 ciphers seem to create problems in some cases. (Credit goes to @pro-src) - Support direct and proxy connections by implementing get_connection (Credit goes to @pro-src)
|
@Anorov could you test and see if you are also no longer seeing a captcha with this latest version? |
N.B. the ciphers were still properly removed
- Remove AES128-SHA ciphers which seem to provoke captchas if python is linked against openssl < 1.1.1
|
@Anorov, @pro-src Please review and let me know what you think. Confirmed to work with the following configurations:
|
ghost
approved these changes
May 14, 2019
|
LGTM As a side note, I don't really like the name of the adapter's class either but I haven't been able to come up with anything much better. Thanks for this! |
|
@Anorov If you find this solution acceptable and decide to merge the pull request, please squash the commits so the history is not polluted. |
mikf
added a commit
to mikf/gallery-dl
that referenced
this pull request
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHA1 ciphers seem to be provoking cloudflare captcha challenges.
By removing cipher AES128-SHA captchas can be avoided.