Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor changes #47

Merged

Conversation

shadow1runner
Copy link
Contributor

I just figured that I made some changes a while back and I forgot to upstream them, mainly because some of which are quite opinionated, just like:

  • building the dockerfile from the current branch might be better than cloning your main branch from scratch
  • exiting upon being unable to connect to MQTT instead of silently gulping

Please check out the changes and let me know what you think; I can also split the PR into multiple if preferred.
Also there's no need to merge each commit -- thanks for your continuous efforts and great work :-)

Copy link
Owner

@AnotherDaniel AnotherDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not 100% sure about the quit-on-failure behavior for the mqtt sink, guess preferences on this one might go both ways depending on the larger system context. But let's try with this approach.

@AnotherDaniel AnotherDaniel merged commit 570451e into AnotherDaniel:main May 12, 2024
2 of 5 checks passed
@shadow1runner shadow1runner deleted the feature/upstream_merge branch May 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants