Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column sorting improvements #18

Closed
iz-sai opened this issue Sep 11, 2013 · 5 comments
Closed

Column sorting improvements #18

iz-sai opened this issue Sep 11, 2013 · 5 comments

Comments

@iz-sai
Copy link
Contributor

iz-sai commented Sep 11, 2013

  • Customize sort direction indicator: it used to be something like △, probably we can add it as a user setting in the main configuration function of AstroTools in the HTML header?
  • Can we probably make some special data-type to sort strings considering them to be astronomical object names? For instance, in such sorting mode "King 8" should come before "King 13" because it's more natural to have strings with same prefix sorted arithmetically by the id afterwards. I may recall it wrong, but in samp-webtools we used to have such sort type because it was explicitly requested by researchers.
AnotherOneAckap added a commit that referenced this issue Sep 17, 2013
@AnotherOneAckap
Copy link
Owner

Added new option for sort icon and new column data type 'astronomical-object-name'

@iz-sai
Copy link
Contributor Author

iz-sai commented Sep 27, 2013

Confirm, everything works. Could you please only leave a check for remaining sorting indicators on other fields? At http://ocl.sai.msu.ru/catalog webpage default sort indicator is returned inside HTML by the webserver, so when user clicks to sort by another column, the original one above α2000 remains there (and if you click on this column heading there will be 2 indicators on it).

@iz-sai
Copy link
Contributor Author

iz-sai commented Sep 29, 2013

Another thing to add is column sorting with "value ± error" content. It used to work in the samp-webtools, but now your code does it wrongly with numeric sort for some reason.

@AnotherOneAckap
Copy link
Owner

Now it tries to parse float in cell, which means longest symbol sequence from string begining which looks like number will be used as sort value, or -Infinity on parsing fail.

@AnotherOneAckap
Copy link
Owner

Is it all about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants