Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ♻️ Further adding of tmp_path #523

Merged
merged 1 commit into from
Dec 18, 2022
Merged

test: ♻️ Further adding of tmp_path #523

merged 1 commit into from
Dec 18, 2022

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Dec 18, 2022

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 18, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.45%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 54.17 ⭐ 55.83 ⭐ 1.66 👎
Working memory 4.00 ⭐ 4.43 ⭐ 0.43 👎
Quality 89.37% 87.92% -1.45% 👎
Other metrics Before After Change
Lines 339 342 3
Changed files Quality Before Quality After Quality Change
spectrafit/test/test_input.py 89.37% ⭐ 87.92% ⭐ -1.45% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added python Pull requests that update Python code testings labels Dec 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #523 (2c8e82d) into main (d771682) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          28       28           
  Lines        2476     2476           
=======================================
  Hits         2462     2462           
  Misses         14       14           
Impacted Files Coverage Δ
spectrafit/test/test_input.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anselmoo Anselmoo merged commit a56807c into main Dec 18, 2022
@Anselmoo Anselmoo deleted the Anselmoo/issue401 branch December 18, 2022 21:37
@Anselmoo Anselmoo added testing Improve testing & coverage and removed testings labels Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code testing Improve testing & coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Using tmp files and pytest fixtures
1 participant