-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ManageServerCard component #178
Create ManageServerCard component #178
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mwgiannini is attempting to deploy a commit to the AnswerOverflow Team on Vercel. A member of the Team first needs to authorize it. |
Could we keep this open until the new design system pr is merged? Otherwise we'll have to open a new issue/pr to make this work with the new design system anyway @RhysSullivan |
Yeah that makes sense @JoltCode - @mwgiannini nice work on this PR I did a quick skim of the code and it looks pretty solid |
Yep - nice work! |
Depends on #146 |
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 85.64% 84.60% -1.05%
==========================================
Files 103 98 -5
Lines 7239 5846 -1393
Branches 1077 926 -151
==========================================
- Hits 6200 4946 -1254
+ Misses 878 812 -66
+ Partials 161 88 -73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work (had a proper look), just now needs a little update with the merge of #146 👍
<div className="col-span-1 col-start-2 row-span-1 row-start-3 flex"> | ||
<div className="ml-auto"> | ||
<Link href={`https://discord.gg/`} target={"Blank"} referrerPolicy="no-referrer"> | ||
<Button intent={"primary"} visualOnly> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now needs to be updated to the new button (path should be the same, just different props and different styles
Sounds good, thanks Jolt |
👍 |
@JoltCode @RhysSullivan This should be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
</div> | ||
<div className="col-span-1 col-start-2 row-span-1 row-start-3 flex"> | ||
<div className="ml-auto"> | ||
<Link href={`https://discord.gg/`} target={"Blank"} referrerPolicy="no-referrer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will open an issue for this - we shouldn't have buttons inside links (needs a component change for button)
#147