Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ManageServerCard component #178

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

mwgiannini
Copy link
Contributor

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
answer-overflow ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 8:01PM (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 8:01PM (UTC)

@vercel
Copy link

vercel bot commented Feb 17, 2023

@mwgiannini is attempting to deploy a commit to the AnswerOverflow Team on Vercel.

A member of the Team first needs to authorize it.

@JoltCode
Copy link
Collaborator

Could we keep this open until the new design system pr is merged? Otherwise we'll have to open a new issue/pr to make this work with the new design system anyway @RhysSullivan

@RhysSullivan
Copy link
Collaborator

Yeah that makes sense @JoltCode - @mwgiannini nice work on this PR I did a quick skim of the code and it looks pretty solid

@JoltCode
Copy link
Collaborator

Yep - nice work!

@JoltCode
Copy link
Collaborator

Depends on #146

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #178 (1154d67) into main (de54ad0) will decrease coverage by 1.05%.
The diff coverage is n/a.

❗ Current head 1154d67 differs from pull request most recent head 4be9340. Consider uploading reports for the commit 4be9340 to get more accurate results

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   85.64%   84.60%   -1.05%     
==========================================
  Files         103       98       -5     
  Lines        7239     5846    -1393     
  Branches     1077      926     -151     
==========================================
- Hits         6200     4946    -1254     
+ Misses        878      812      -66     
+ Partials      161       88      -73     
Impacted Files Coverage Δ
packages/db/src/utils/error.ts 54.54% <0.00%> (-39.21%) ⬇️
.../listeners/events/forum-post-guidelines-consent.ts 63.63% <0.00%> (-36.37%) ⬇️
packages/db/src/ignored-discord-account.ts 48.57% <0.00%> (-34.29%) ⬇️
packages/db/src/channel.ts 77.60% <0.00%> (-21.35%) ⬇️
packages/elastic-types/src/elastic.ts 55.42% <0.00%> (-11.50%) ⬇️
packages/db/src/server.ts 87.17% <0.00%> (-10.01%) ⬇️
...outer/user-server-settings/user-server-settings.ts 90.59% <0.00%> (-9.41%) ⬇️
packages/api/src/router/message/message.ts 78.49% <0.00%> (-5.64%) ⬇️
packages/db/src/discord-account.ts 73.03% <0.00%> (-4.52%) ⬇️
packages/db/src/utils/operations.ts 48.33% <0.00%> (-1.67%) ⬇️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@JoltCode JoltCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work (had a proper look), just now needs a little update with the merge of #146 👍

<div className="col-span-1 col-start-2 row-span-1 row-start-3 flex">
<div className="ml-auto">
<Link href={`https://discord.gg/`} target={"Blank"} referrerPolicy="no-referrer">
<Button intent={"primary"} visualOnly>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now needs to be updated to the new button (path should be the same, just different props and different styles

@mwgiannini
Copy link
Contributor Author

Sounds good, thanks Jolt

@JoltCode
Copy link
Collaborator

👍

@mwgiannini
Copy link
Contributor Author

@JoltCode @RhysSullivan This should be ready to merge.

Copy link
Collaborator

@JoltCode JoltCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

</div>
<div className="col-span-1 col-start-2 row-span-1 row-start-3 flex">
<div className="ml-auto">
<Link href={`https://discord.gg/`} target={"Blank"} referrerPolicy="no-referrer">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open an issue for this - we shouldn't have buttons inside links (needs a component change for button)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛ component Issue relates to a react component 🖥️website Relates to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants