Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): use slurm sinfo command to improve "cluster load" indicator #1664

Merged
merged 7 commits into from Feb 2, 2024

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Jul 24, 2023

The branch name does not have anything to do with this PR, my bad.

There's a PR linked to it on antares-cd which includes the partition in the application.yaml file.
This PR has been merged.

@commit-lint
Copy link

commit-lint bot commented Jul 24, 2023

Features

  • service: add sinfo command to retrieve cluster load (3905bcf)

Bug Fixes

  • config: add default value for partition (26a7c21)

Contributors

MartinBelthle

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@MartinBelthle MartinBelthle changed the title Fix/launcher cannot export zipped outputs feat(service): use slurm info to improve "cluster load" indicator Jul 24, 2023
@MartinBelthle MartinBelthle force-pushed the fix/launcher_cannot_export_zipped_outputs branch from 0c948e8 to 6c2d14c Compare August 21, 2023 08:04
@laurent-laporte-pro laurent-laporte-pro changed the title feat(service): use slurm info to improve "cluster load" indicator feat(service): use slurm sinfo command to improve "cluster load" indicator Aug 21, 2023
@MartinBelthle MartinBelthle force-pushed the fix/launcher_cannot_export_zipped_outputs branch from 6c2d14c to 96d4ec5 Compare August 28, 2023 09:22
@laurent-laporte-pro laurent-laporte-pro added this to the v2.16 milestone Nov 17, 2023
@MartinBelthle MartinBelthle force-pushed the fix/launcher_cannot_export_zipped_outputs branch from 96d4ec5 to 3905bcf Compare November 17, 2023 15:53
@laurent-laporte-pro laurent-laporte-pro modified the milestones: v2.16, v2.16.1 Nov 27, 2023
@laurent-laporte-pro laurent-laporte-pro modified the milestones: v2.16.1, v2.16.2 Dec 12, 2023
@laurent-laporte-pro laurent-laporte-pro modified the milestones: v2.16.2, v2.16.3 Jan 4, 2024
@laurent-laporte-pro laurent-laporte-pro modified the milestones: v2.16.3, v2.16.4 Jan 15, 2024
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/launcher_cannot_export_zipped_outputs branch from 26a7c21 to da739be Compare February 2, 2024 09:03
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/launcher_cannot_export_zipped_outputs branch from da739be to 140126b Compare February 2, 2024 09:45
@laurent-laporte-pro
Copy link
Collaborator

laurent-laporte-pro commented Feb 2, 2024

Curieusement, en intégration, l'indicateur donne :

{
  "allocatedCpuRate": 0,
  "clusterLoadRate": 0.6666666666666667,
  "nbQueuedJobs": 2,
  "launcherStatus": "SUCCESS"
}

Alors qu'a priori, il n'y a rien qui tourne sur ce serveur…

Copy link
Collaborator

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mise à jour de la documentation pour le nouveau paramètre partition.

Meilleure gestion du paramètre partition lorsqu'il est vide.

Gestion des erreurs lorsque la partition n'existe pas.

requirements.txt Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Feb 2, 2024
@laurent-laporte-pro laurent-laporte-pro merged commit ab7bc4b into dev Feb 2, 2024
6 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the fix/launcher_cannot_export_zipped_outputs branch February 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants