feat(parameters): handle the --partition and --qos parameters for the sbatch command
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For backward compatibility, the |
|
We will also have another similar request to use the |
…Features` constructor
…meter for the `sbatch` command
laurent-laporte-pro
approved these changes
Sep 18, 2023
laurent-laporte-pro
changed the title
--partition and --qos parameters for the sbatch command
laurent-laporte-pro
added a commit
that referenced
this pull request
Sep 19, 2023
… the `sbatch` command (#58) * feat(parameters): add partition in MainParameters * refactor: simplify the implementation of `SlurmScriptFeatures.compose_launch_command` * refactor(parameters-reader): simplify the implementation of the parameters reader * refactor(parameters-reader): change the signature of the `SlurmScriptFeatures` constructor * style(parameters-reader): sort imports and reformat source code * feat(parameters-reader): make the `partition` parameter optional * feat(parameters-reader): handle the `--qos` (quality of service) parameter for the `sbatch` command --------- Co-authored-by: Laurent LAPORTE <laurent.laporte.pro@gmail.com>
laurent-laporte-pro
added a commit
that referenced
this pull request
Sep 20, 2023
… the `sbatch` command (#58) * feat(parameters): add partition in MainParameters * refactor: simplify the implementation of `SlurmScriptFeatures.compose_launch_command` * refactor(parameters-reader): simplify the implementation of the parameters reader * refactor(parameters-reader): change the signature of the `SlurmScriptFeatures` constructor * style(parameters-reader): sort imports and reformat source code * feat(parameters-reader): make the `partition` parameter optional * feat(parameters-reader): handle the `--qos` (quality of service) parameter for the `sbatch` command --------- Co-authored-by: Laurent LAPORTE <laurent.laporte.pro@gmail.com>
laurent-laporte-pro
added a commit
that referenced
this pull request
Sep 20, 2023
* feat(parameters): handle the `--partition` and `--qos` parameters for the `sbatch` command (#58) * feat(parameters): add partition in MainParameters * refactor: simplify the implementation of `SlurmScriptFeatures.compose_launch_command` * refactor(parameters-reader): simplify the implementation of the parameters reader * refactor(parameters-reader): change the signature of the `SlurmScriptFeatures` constructor * style(parameters-reader): sort imports and reformat source code * feat(parameters-reader): make the `partition` parameter optional * feat(parameters-reader): handle the `--qos` (quality of service) parameter for the `sbatch` command --------- Co-authored-by: Laurent LAPORTE <laurent.laporte.pro@gmail.com> * feat(cli): add the `--solver-version` option to the command line * test: correct unit tests `test_data_repo_tinydb` which were not reentrant * feat(cli): add the `--solver-version` parameter to the command line * test(assets): correct the import used to import the `ASSETS_DIR` constant * chore(typing): correct typing in `remote_environment_with_slurm` module * chore: correct the way class name is displayed with `show_message` --------- Co-authored-by: MartinBelthle <102529366+MartinBelthle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the PR AntaresSimulatorTeam/AntaREST#1664