Simplify TS numbers drawings, fix bug related to refresh & local thermal generation #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom TS generation and move it before TS number drawings
…S numbers drawing + simplification on TS number drawing
sylvlecl
reviewed
Nov 8, 2023
| { | ||
| for (auto i = areas.begin(); i != areas.end(); ++i) |
There was a problem hiding this comment.
We should use range-based for loop, no need for iterator.
There was a problem hiding this comment.
Done : for this, I used each()
…iesToGenerate to stay consistent with other part of the code. But whether we should use one or the other in the code requires thinking, and possibly change
… from intra-modal check
… from intra-modal check (part 2)
… from intra-modal check (part 3)
…ition mode from intra-modal check (part 4)
…tra modal consistency checker
payetvin
reviewed
Dec 11, 2023
This was referenced Dec 11, 2023
flomnes
reviewed
Dec 11, 2023
This was referenced Dec 12, 2023
![watermelon-copilot-for-code-review[bot]](https://avatars.githubusercontent.com/in/327523?s=60&v=4){kind=small}
| @@ -38,8 +38,6 @@ using namespace Yuni; | |||
| namespace Antares::Data | |||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
This was referenced Dec 13, 2023
This was referenced Dec 22, 2023
flomnes
changed the title
|
This was referenced Dec 29, 2023
flomnes
approved these changes
Jan 11, 2024
Merged
flomnes
added a commit
that referenced
this pull request
Jan 11, 2024
Update reference results. They changed after #1752, in the case where thermal refresh is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to simplify and clarify the TS number management (specially source file timeseries-numbers.cpp).
For this we did several things :