Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled property for ST storage objects, fix bug related to saving ST objects #1807

Merged
merged 20 commits into from
Dec 19, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 4, 2023

  • Add bool property enabled for each ST storage object
  • Whenever a ST storage is not enabled, remove it from computations relatively early (right after loading the data), using a similar mechanism as thermal & renewable clusters
  • Also fix list.ini files containing only the last ST storage object because of overwrite, add unit test case
  • Cherry-pick of "Remove sts container (Remove sts container #1804)"

@flomnes flomnes added this to the v8.8.0 milestone Dec 4, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 4, 2023
@flomnes flomnes modified the milestones: v8.8.0, v8.9.0 Dec 4, 2023
Copy link

watermelon-copilot-for-code-review bot commented Dec 11, 2023

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

Copy link
Member Author

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of

for (...)
    if (!cluster.enabled()) continue;

we could expose an iterator to iterate over enabled clusters only. WDYT ?

@flomnes
Copy link
Member Author

flomnes commented Dec 13, 2023

Check indexes for pValuesForTheCurrentYear, possibly elsewhere.

Copy link
Member Author

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test on the save function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename short-term-storage-input-output.cpp

@flomnes flomnes changed the title Add enabled property for ST storage objects Add enabled property for ST storage objects, fix bug related to saving ST objects Dec 19, 2023
@flomnes flomnes merged commit 628f070 into release/8.8.x Dec 19, 2023
5 checks passed
@flomnes flomnes deleted the feature/enable-st-storage branch December 19, 2023 15:44
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

4.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants