Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account breaking change in OR-Tools's API, enable SCIP & GLPK solvers, bump OR-Tools #1825

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 15, 2023

  • SetStartingLpBasisInt and GetFinalBasisInt have been removed from recent versions, due to redundancy with their non-Int counterparts.
  • Bump OR-Tools v9.5-rte2.0 -> v9.5-rte3.0
  • Add SCIP solver in lookup list (works better for MILP) and GLPK

Copy link

watermelon-copilot-for-code-review bot commented Dec 15, 2023

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

@flomnes flomnes changed the title Take into account breaking change in OR-Tools's API Take into account breaking change in OR-Tools's API, enable SCIP solver, bump OR-Tools Dec 27, 2023
@flomnes flomnes changed the title Take into account breaking change in OR-Tools's API, enable SCIP solver, bump OR-Tools Take into account breaking change in OR-Tools's API, enable SCIP & GLPK solvers, bump OR-Tools Dec 27, 2023
@@ -289,6 +289,17 @@ MPSolver* ORTOOLS_ConvertIfNeeded(const std::string& solverName,
}
}

template<class SourceT>
static void transferBasis(std::vector<operations_research::MPSolver::BasisStatus>& destination,
const SourceT& source)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aurais trouvé plus logique une signature tranferBasis(source, destination) plutôt que tranferBasis(destination, source)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On utilise la convention destination = source, où destination est à gauche du signe égal.

Copy link

sonarcloud bot commented Jan 8, 2024

@flomnes flomnes merged commit d8b2407 into develop Jan 8, 2024
6 checks passed
@flomnes flomnes deleted the fix/or-tools-api-breaking-change branch January 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants