Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture explicit var for lambdas #2170

Merged
merged 27 commits into from
Jun 17, 2024
Merged

Capture explicit var for lambdas #2170

merged 27 commits into from
Jun 17, 2024

Conversation

payetvin
Copy link
Contributor

close #2169

@payetvin payetvin self-assigned this Jun 14, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 14, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 14, 2024
@payetvin payetvin marked this pull request as ready for review June 17, 2024 09:05
@payetvin payetvin requested a review from flomnes June 17, 2024 09:14
@payetvin payetvin changed the title Capture explicit var for lamdas Capture explicit var for lambdas Jun 17, 2024
@flomnes
Use local struct to capture multiple IniFile::Section* (#2172)
f53920b 
This was the last instance of `[&]` in the code.
flomnes
flomnes reviewed Jun 17, 2024
View reviewed changes
src/solver/ts-generator/hydro.cpp
@@ -180,7 +180,6 @@ bool GenerateHydroTimeSeries(Data::Study& study, uint currentYear, Solver::IResu

uint month = i % 12;
uint realmonth = calendar.months[month].realmonth;
uint daysPerMonth = calendar.months[month].days;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused ?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@flomnes flomnes merged commit 708128c into develop Jun 17, 2024
6 of 7 checks passed
@flomnes flomnes deleted the fix/lambda branch June 17, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees

@payetvin payetvin

Labels
cleaning code quality size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly capture context in lambda functions
2 participants
@payetvin @flomnes