[4.0] SHiP: Improve startup when large number of SHiP logs in retain directory #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jul 10, 2023
spoonincode
reviewed
Jul 10, 2023
| #include <fc/io/cfile.hpp> | ||
| #include <fc/io/datastream.hpp> | ||
| #include <boost/filesystem/path.hpp> | ||
| #include <boost/iostreams/device/mapped_file.hpp> |
There was a problem hiding this comment.
Can mapped_file.hpp be removed? I don't see it being used.
linh2931
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup of
state_history_pluginwas very slow when large number of SHiP logs were in theretaindirectory. Almost all the performance slowness was due to use ofboost::flat_mapas it sorts and inserts into avectoron each insert. Changing to use astd::mapprovides much more reasonable performance on startup. Also included in this PR are additional small performance improvements to the scanning of the log/indexs during startup. For my test case, improved from 76 seconds to 7 seconds.Resolves #1331