Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] SHiP: Improve startup when large number of SHiP logs in retain directory #1385

Merged
merged 8 commits into from
Jul 11, 2023
Merged

[4.0 -> main] SHiP: Improve startup when large number of SHiP logs in retain directory #1385

merged 8 commits into from
Jul 11, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 10, 2023

Startup of state_history_plugin was very slow when large number of SHiP logs were in the retain directory. Almost all the performance slowness was due to use of boost::flat_map as it sorts and inserts into a vector on each insert. Changing to use a std::map provides much more reasonable performance on startup. Also included in this PR are additional small performance improvements to the scanning of the log/indexs during startup. For my test case, improved from 76 seconds to 7 seconds.

Merges release/4.0 into main including #1384

Resolves #1331

@heifner heifner added the OCI Work exclusive to OCI team label Jul 10, 2023
@heifner heifner merged commit 8b43915 into main Jul 11, 2023
21 checks passed
@heifner heifner deleted the GH-1331-slow-main branch July 11, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LEAP 4.0.3 - Long startup time after upgrade to 4.0.3.
3 participants
@heifner @greg7mdp @linh2931