Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: set_finalizers updates #1598

Merged
merged 16 commits into from
Sep 7, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 5, 2023

  • Add finalizer_set to block_header extension
  • Add last_proposed_finalizer_set_generation to block_header_state
  • Add set_finalzers host function to eos-vm-oc/intrinsic_mapping
  • Add to/from variant tests for bls_public_key
  • Add activate protocol feature instant finality host function set_finalizers unittest.

Note: snapshot tests are failing because of block_header_state addition of last_proposed_finalizer_set_generation. I think the snapshot test should be fixed as part of #1558. I've commented it out and added a warning for now.

@heifner heifner added the OCI Work exclusive to OCI team label Sep 6, 2023
@heifner heifner linked an issue Sep 6, 2023 that may be closed by this pull request
@heifner heifner merged commit a24b4b4 into hotstuff_integration Sep 7, 2023
22 checks passed
@heifner heifner deleted the GH-1523-finalizer-set-transition-2 branch September 7, 2023 13:07
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: CONSENSUS
summary: Updated block header state adding last_proposed_finalizer_set_generation and adding finalizer_set to block header extension. Created host function and protocol feature set_finalizers.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Support transition from legacy consensus to HotStuff consensus
4 participants