Make episodes not in inbox eligible for auto-download #6671

Husaberger · 2023-10-01T00:04:03Z

Checklist

I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
I will describe the problem with as much detail as possible.
If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.1.1

Where did you get the app from

Google Play

Android version

13

Device model

Pixel 7

First occurred

3 months ago

Steps to reproduce

All podcasts only download manually despite uninstall/reinstall. All auto download settings unchanged from when AP did auto downloaded

Expected behaviour

Auto download

Current behaviour

Not auto download

Logs

No response

Husaberger · 2023-10-01T00:04:40Z

Environment

Android version: 13
OS version: 5.10.157-android13-4-00003-g776d0a76f6aa-ab10208116
AntennaPod version: 3.1.1
Model: Pixel 7
Device: panther
Product: panther

No crash report recorded

ByteHamster · 2023-10-01T06:41:02Z

Do you use a VPN? Try turning it off.

Husaberger · 2023-10-01T11:33:41Z

No VPN is bring used

ByteHamster · 2023-10-01T11:52:57Z

WiFi or mobile network? "Automatic download when on battery" enabled? Is there a little icon next to the downloads section on the navigation bar?

Husaberger · 2023-10-01T12:06:45Z

Both WiFi and mobile
Download when not charging currently off- but also fails to auto download when toggled on
Do not see download icon even when manually downloading

maniyasujit · 2023-10-03T09:09:04Z

Yes, I faced the same issue yesterday while I was downloading the podcast. (I have a debug version of the application that I have installed using Android Studio).

Husaberger · 2023-10-04T21:41:16Z

they must have changed something because now all podcasts are auto downloading again

JasonMaggini · 2023-10-10T15:31:38Z

I'm having this issue as well. Automatic downloads just don't work. Battery settings, charging, not charging, wifi, mobile, no combination of anything has worked for me. I've changed episode cache up and down, I've wiped all the data, reinstalled, tried only one podcast subscription, nothing.

Husaberger · 2023-10-10T16:22:26Z

Most of my podcasts now download automatically. I only have 2 that do not. Would like to know if AP changed something to make most of them download automatically

ByteHamster · 2023-10-10T17:21:25Z

No, we did not change anything. There was no update and we do not have a server that we could change.

Husaberger · 2023-10-10T17:29:34Z

What do you think changed then?

…

________________________________ From: ByteHamster ***@***.***> Sent: Tuesday, October 10, 2023 10:21:37 AM To: AntennaPod/AntennaPod ***@***.***> Cc: Husaberger ***@***.***>; Author ***@***.***> Subject: Re: [AntennaPod/AntennaPod] Auto download not working (Issue #6671) No, we did not change anything. There was no update and we do not have a server that we could change. — Reply to this email directly, view it on GitHub<#6671 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BC5TGU5F46CA6E6I5X7YCCLX6V72DAVCNFSM6AAAAAA5N4ELPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVHEYDONZWGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

tonytamsf · 2023-10-10T20:56:40Z

for people who have problems, go to Downloads and click on history. what you are describing is a problem on the server side that AntennaPod does not control.

here is a screenshot showing problems specific to the feeds I am subscribed to

JasonMaggini · 2023-10-10T21:00:46Z

Download log is blank on mine, as the app will never attempt to automatically download, regardless of settings.

JasonMaggini · 2023-10-11T23:58:40Z

After some experimenting, it seems like 3.0.2 is the last version that will reliably autoupdate for me.

Husaberger · 2023-10-12T02:28:47Z

for people who have problems, go to Downloads and click on history. what you are describing is a problem on the server side that AntennaPod does not control.

here is a screenshot showing problems specific to the feeds I am subscribed to

Helpful
Did not know that log existed

rahqbo · 2023-11-30T23:34:09Z

I too have this problem. I updated from Arrowos Android 12.1 to Crdroid Android 13 and installed Antennapod again, fresh. Auto download active, also when not charging. Podcasts are coming in, but not getting downloaded. The Antennapod version has not changed, both the latest from F-Droid.

keunes · 2023-12-02T08:13:13Z

Download log is blank on mine, as the app will never attempt to automatically download, regardless of settings.

@JasonMaggini The log should also display items that you manually downloaded. Did you try that?

After some experimenting, it seems like 3.0.2 is the last version that will reliably autoupdate for me.

Here you can see the code changes that landed after 3.0.2 until & including 3.1.1 (which is the version mentioned in the first post):

3.0.2...3.1.1

Maybe you can check if there are any changes that might point to anything related to (auto)downloads?

keunes · 2023-12-02T08:16:13Z

Just a thought @JasonMaggini; is your auto refresh enabled? Without refresh no auto-download.

damoasda · 2023-12-03T09:07:30Z

I had the same issue. After I switched the setting "New episodes action" back to "Add to inbox", it worked again for me.

This behaviour is caused by the method DBTasks.updateFeed():

if (action == FeedPreferences.NewEpisodesAction.ADD_TO_INBOX
        && (item.getPubDate() == null
            || priorMostRecentDate == null
            || priorMostRecentDate.before(item.getPubDate())
            || priorMostRecentDate.equals(item.getPubDate()))) {
    Log.d(TAG, "Marking item published on " + item.getPubDate()
            + " new, prior most recent date = " + priorMostRecentDate);
    item.setNew();
}

This seems to be a feature, implemented in February this year, see #6442.

rahqbo · 2023-12-12T16:54:18Z

I had the same issue. After I switched the setting "New episodes action" back to "Add to inbox", it worked again for me.

This behaviour is caused by the method DBTasks.updateFeed():
if (action == FeedPreferences.NewEpisodesAction.ADD_TO_INBOX
        && (item.getPubDate() == null
            || priorMostRecentDate == null
            || priorMostRecentDate.before(item.getPubDate())
            || priorMostRecentDate.equals(item.getPubDate()))) {
    Log.d(TAG, "Marking item published on " + item.getPubDate()
            + " new, prior most recent date = " + priorMostRecentDate);
    item.setNew();
}
This seems to be a feature, implemented in February this year, see #6442.

I can confirm your findings.

keunes · 2023-12-13T06:11:42Z

Ping @terminalmage. Would you have any idea?

ByteHamster · 2023-12-13T06:26:55Z

This is intended. Only episodes in the inbox are eligible for auto-download.

keunes · 2023-12-13T11:39:41Z

I think we need to re-discuss. If the user wants to skip the inbox, it can be because they don't want it (for which there are other methods) or because they want all of them.

ByteHamster · 2023-12-13T14:55:46Z

If you want all of them, enabling the inbox makes no difference because they are removed again once downloaded

keunes · 2023-12-13T16:58:21Z

If you want all of them, enabling the inbox makes no difference because they are removed again once downloaded

Exactly. So why, if all episodes of a given podcast should be downloaded anyway, do we make them appear briefly in the Inbox without purpose.

ByteHamster · 2023-12-13T17:59:02Z

If you hit your auto-download limit or if all retries fail, it remains in the inbox

rahqbo · 2023-12-13T19:25:11Z

I propose some kind of hint for this behaviour in the settings. Something like "Disabling the inbox disables auto-downloads, too." or "The inbox is required for auto-downloads to work." or "Only podcasts appearing in the inbox are elegible for auto-download." Or grey out the auto-download settings when the inbox is disabled.

LRitzdorf · 2023-12-24T00:07:25Z

Just my two cents, as a recent switch-over from Google Podcasts: I encountered this issue because I use my push notifications as something of an inbox. I just don't see the utility of the in-app inbox for my personal workflow.

Before finding this issue, I wouldn't have expected the current behavior at all — this may just be me, but I inferred the "new episode" flow to be "notify (inbox, push, or maybe both), then optionally download." Accordingly, I had disabled the inbox, then enabled push notifications and auto-download.

The fact that downloaded episodes are removed from the inbox helps, but that means I currently need to touch two settings per podcast to actually allow downloads: enabling the inbox, and then enabling auto-download.

Related question: is the inbox also required for push notifications to work? I found this thread after an episode failed to download (because no inbox), and I don't recall having seen a push notification for that episode, either. (That one episode is the only one to have been released since I switched to AntennaPod, so my testing is a bit limited, sorry.)

keunes · 2023-12-24T07:38:50Z

is the inbox also required for push notifications to work?

As far as I'm aware, it is not. However, episode notifications are not enabled by default, and must be activated at the level of podcasts.

terminalmage · 2023-12-29T15:56:03Z

When I added the option to skip the inbox, I misunderstood what @ByteHamster mentioned here. Like @rahqbo, the inbox just doesn't make sense for me. In fact, it actually makes the user experience worse. I subscribe to several feeds which include "full show" and hourly episodes in the same feed. I don't want to listen to all of them, obviously, because there is a lot of duplication. So I do the following:

Configure auto-download filters for that feed to exclude the hourly episodes
Mark the hourly episodes as played

However, this leaves the undownloaded episodes in the inbox. So when I use the swipe action to change played state, I have to swipe once to remove from the inbox, and a second time to mark as played.

ByteHamster · 2023-12-29T16:03:07Z

@terminalmage Keunes and I had a 3-hour meeting yesterday and discussed how to deal with this. We decided to do a rewrite of the auto-download feature, so that it becomes independent from the inbox.

terminalmage · 2023-12-29T16:19:27Z

Oh, nice! That would definitely help.

keunes · 2023-12-30T09:19:40Z

Currently writing up the forum post with full notes of our meeting. Will share the link here once it's ready.

I subscribe to several feeds which include "full show" and hourly episodes in the same feed. I don't want to listen to all of them, obviously, because there is a lot of duplication. So I do the following:

Configure auto-download filters for that feed to exclude the hourly episodes

Mark the hourly episodes as played

@terminalmage I guess that, alternative to having the 'new episode action' setting, the combination of #6054 + #5237 would cover you as well.

ByteHamster · 2023-12-30T09:29:04Z

I guess that, alternative to having the 'new episode action' setting

Wait, so now we are considering removing the setting again?

keunes · 2023-12-30T12:22:22Z

Wait, so now we are considering removing the setting again?

You said it first! 😉

I would keep it, because I think it's still valid/useful for other use cases.

antennapod-bot · 2023-12-31T12:26:51Z

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/new-episode-action-enhancement/3871/1

Husaberger added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Oct 1, 2023

This was referenced Oct 12, 2023

Refresh does not work in FTTH Wifi #6647

Closed

Feed has two episodes release simultaneously, only one gets downloaded #6241

Closed

keunes added Needs: Decision Proposal and most arguments are clear, but needs a verdict. Type: Enhancement and removed Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet labels Dec 13, 2023

keunes mentioned this issue Dec 24, 2023

Add "New Episodes Action" preference #6095

Merged

AntennaPod deleted a comment from antennapod-bot Jan 4, 2024

ByteHamster changed the title ~~Auto download not working~~ Make episodes not in inbox eligible for auto-download Jan 26, 2024

keunes added the Type: Feature request label Feb 28, 2024

ByteHamster removed the Type: Enhancement label Feb 28, 2024

Make episodes not in inbox eligible for auto-download #6671

Make episodes not in inbox eligible for auto-download #6671

Comments

Husaberger commented Oct 1, 2023

Checklist

App version

Where did you get the app from

Android version

Device model

First occurred

Steps to reproduce

Expected behaviour

Current behaviour

Logs

Husaberger commented Oct 1, 2023

Environment

ByteHamster commented Oct 1, 2023

Husaberger commented Oct 1, 2023

ByteHamster commented Oct 1, 2023

Husaberger commented Oct 1, 2023

maniyasujit commented Oct 3, 2023 • edited

Husaberger commented Oct 4, 2023

JasonMaggini commented Oct 10, 2023

Husaberger commented Oct 10, 2023

ByteHamster commented Oct 10, 2023

Husaberger commented Oct 10, 2023 via email

tonytamsf commented Oct 10, 2023

JasonMaggini commented Oct 10, 2023

JasonMaggini commented Oct 11, 2023

Husaberger commented Oct 12, 2023

rahqbo commented Nov 30, 2023 • edited

keunes commented Dec 2, 2023

keunes commented Dec 2, 2023

damoasda commented Dec 3, 2023

rahqbo commented Dec 12, 2023

keunes commented Dec 13, 2023

ByteHamster commented Dec 13, 2023

keunes commented Dec 13, 2023

ByteHamster commented Dec 13, 2023

keunes commented Dec 13, 2023

ByteHamster commented Dec 13, 2023

rahqbo commented Dec 13, 2023 • edited

LRitzdorf commented Dec 24, 2023

keunes commented Dec 24, 2023

terminalmage commented Dec 29, 2023

ByteHamster commented Dec 29, 2023

terminalmage commented Dec 29, 2023

keunes commented Dec 30, 2023 • edited

ByteHamster commented Dec 30, 2023

keunes commented Dec 30, 2023

antennapod-bot commented Dec 31, 2023

maniyasujit commented Oct 3, 2023 •

edited

rahqbo commented Nov 30, 2023 •

edited

rahqbo commented Dec 13, 2023 •

edited

keunes commented Dec 30, 2023 •

edited