Rating Dialog

[mfietz]

7 days after the first app start (or 7 days after the upgrade):

If the user chooses remind me later, we wait another 7 days and show the dialog again.

[keunes]

Nice

[johnjohndoe]

@mfietz Are you going to add translated strings for other languages?

[mfietz]

@johnjohndoe After this has been merged, we will push the strings to Transifex where they will be translated.

[johnjohndoe]

@mfietz Is it also possible to request stings from Transifex while you are on the branch? This would enable to collect all needed data first before it is merged into master?

[mfietz]

@johnjohndoe Transifex is no automatic translation service (at least we are not using it that way). We upload the new strings (in english, only) and volunteers translate the strings manually via their web interface. Later, we pull the translations. (I could have added translations for German, but we would then have to merge my "local" changes with changes already made on Transifex - translations of so far untranslated strings or changes to the translation -, I don't see any use in making it any more complicated than it already is)

Transifex can make suggestions for a translations, but they are not reliable enough.

[johnjohndoe]

Understood. Does this also work while you are on the branch?

[mfietz]

Why shouldn't it?
In the repo, we are the only ones writing to the english strings, all the other languages are only ever updated by pulling translations from transifex. No conflicts.

[johnjohndoe]

I was not thinking about conflicts, just about a complete feature branch. It appeared incomplete to me for being merged into master (where potentially automatic checks could run to approve that strings in all languages are present).

[mfietz]

What would we gain from such checks?
Android won't complain, if a language lacks a translation, it just uses the english string.
What to do with the information that a language is incomplete? If there are not volunteers to translate a language or new strings, we just have to live with that

[johnjohndoe]

Such a check could be used as an automated quality control. Running it via continuous integration (such as Travis CI) would warn you before the branch is merged. - On the other hand it is a matter of agreement of the project setup. If you already decided that a fallback to English is fine then this what we all should be aware of.

[keunes]

I guess automated quality control would be nice, but some flexibility as to not bothering developers if a few strings are missing would be a requirement (accepting English as a fallback, indeed). I.e. only show a warning if less than 75% of the strings are translated. But doubt that's easy to set up or even possible.
Note that some kind of check seems to be done by the developers themselves.