Fix gradle free builds

[drabux]

Replaces #1996, follows #1982 to resolve #1959.
Here is a new solution that fix the flavor and build variants build under gradle and seems to integrate better with android studio.
To make a free build -DfreeBuildHackDoFreeBuild=true must be passed to gradle, ex:./gradlew clean assembleFreeRelease -DfreeBuildHackDoFreeBuild=true

@mvdan and @mfietz : are you ok with this solution?

This solution is better that #1996 cause the build variants are correctly linked on Android Studio.

For the record:

• Using different build files was not possible due to: GRADLE-2624
• build variants fix from: http://stackoverflow.com/a/29661804

[mfietz]

I like it, but freeBuildHackDoFreeBuild is just horrible.
Couldn't we shorten that to just freeBuild, i.e. -DfreeBuild=true would be passed?

Looks like F-Droid recipes only support setting gradle/project properties (-P) [1].
Maybe return hasProperty("freeBuild")? (we can omit =true)

[1] https://f-droid.org/manual/fdroid.html#Build

[drabux]

Looks like F-Droid recipes only support setting gradle/project properties (-P) [1].
Maybe return hasProperty("freeBuild")? (we can omit =true)

Yes, that's better, patch done.

[mfietz]

Github currently has issues. Will retry and merge this asap.

Edit: https://status.github.com/ Interesting, everything spiked and then the app server was gone

[mfietz]

Woah, this is so weird. Merging always fails, this PR is not in the commits.
When I do a git pull locally, I do see the commit o_O

Edit: I contacted the Github support. The repo is "broken" due to a service failure. I hope to hear back soon.

[mfietz]

GitHub support cleared the cache, repo is back to normal.
I could close this PR, because it has already been merged.