Added ExoPlayer #2655
Added ExoPlayer #2655
Conversation
| @@ -6,34 +6,24 @@ | |||
| import java.io.IOException; | |||
|
|
|||
| public interface IPlayer { | |||
There was a problem hiding this comment.
are these not needed anymore?
There was a problem hiding this comment.
Intellij told me they are unused. Additionally, every class that implemented them was just throwing RuntimeExceptions in those methods (see diff). So I just removed them (ExoPlayer does not seem to support those things anyway)
Casting magic values to int is not a good idea...
|
I hope Exoplayer gets added because it has been such a blessing to other open source apps and it is essential that Antennapod have bugfree playback with full streaming support of the new Opus format. |
|
Glad this is finally being merged. Exoplayer will improve playback across the board for this great client! |
|
@ByteHamster Exoplayer 2.8.4 is out. |
|
@RIOTOUS We will release 2.7.3 first because that version was already tested. Otherwise the release would need even more time |
| @@ -107,7 +108,6 @@ | |||
| private static final String PREF_RIGHT_VOLUME = "prefRightVolume"; | |||
|
|
|||
| // Experimental | |||
| public static final String PREF_SONIC = "prefSonic"; | |||
There was a problem hiding this comment.
I realize this has already been merged, but I just wanted to say that the sonic player test still depends on this.
https://github.com/AntennaPod/AntennaPod/blob/develop/app/src/androidTest/java/de/test/antennapod/ui/PlaybackSonicTest.java#L62
That being said, I just started looking into this codebase this evening and as of right now all tests are still failing for me, so I'm not sure whether I should make a PR for that. 😅
There was a problem hiding this comment.
I'm currently working on fixing the tests in #2870 ;)
|
@ByteHamster, with this PR merged, is ExoPlayer now the default, actually? (asking because of #2783 (comment)) |
|
@keunes No, it's not the default player. Before making it the default player, we need to fix the player settings menu first: Downmixing and independent L/R volume control do not work. After that, I prefer to wait some time to find out if anyone has issues with the player before changing the default. |
Should fix a lot of crashes when trying opus or other formats
ToDo:
Closes #2631