Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move top bottom #98

Closed
wants to merge 6 commits into from
Closed

Conversation

lacouture
Copy link

Hi again.

Here's my first real feature pull request, eventhough it's a rather modest one.

I spend a lot of time moving the episodes from the bottom to the top of the queue, one line after the other. So here's a proposed commit with "Move to top" and "Move to bottom" entries in the queue item menu.

I translated these entries only in German (feel free to check, as I haven't spoken German for quite a while), English and French.

Best regards

Patrice LACOUTURE

@danieloeh
Copy link
Member

Hello,
Thanks for your contribution, but i'm afraid i am not going to merge this pull request. The reason is that the current way of moving items around in the queue (move up/ move down menu items) is very unintuitive and is probably going to be replaced by drag & drop reordering (issue #39) in one of the next versions, making menu items for moving up/down/to the top/to the bottom unnecessary.

@danieloeh danieloeh closed this Jan 22, 2013
@lacouture
Copy link
Author

Thumbs up to that. I actually thought the drag and drop is definitely the way to go, but the "move to top/bottom" workaround is about the only effort I could dedicate to it right now, and it jusk works for me for the time being. I'll keep it for my own usage and merge back your changes until you come up with the better solution (unless I manage to implement it on my side, but we can't count on that these days!).

Anyway, thanks and keep up the good job with this nice podcatcher.

@e2jk
Copy link

e2jk commented Jan 24, 2013

Agreed, drag/drop is much better. However, the move to top/bottom functionality here has the merit of existing today, whereas the drag/drop can take time to implement.
By all means, if you feel drag/drop can be implemented soon, don't waste time merging this, but in doubt, it might already be a small step forward to include this code?

@danieloeh
Copy link
Member

@e2jk
I am currently working on 0.9.7 and i am probably going to implement drag and drop reordering in that version. This will take some time, but i wasn't planning to do any other releases before that.

@TomHennen
Copy link
Contributor

@danieloeh I appreciate all the flexibility of the drag/drop that was introduced. However, I don't think the usability is very good when the user has a large queue. Moving an item from the bottom to top when the queue is larger than the screen (like say 2 to 3 times larger) involves a lot of interaction from the user. I think there's a place for both of these features in the product.

My pull request (#258) integrates this feature in to the current version (as this one did previously).

Do you think there is any room for this feature in your product?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants