-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to top/bottom #258
Move to top/bottom #258
Conversation
…m at the top of the queue. There may be a way to do this while re-using the existing move function. Perhaps a helper is in order.
…ottom coming soon.
* added 'move to bottom'
I think i understand why this feature can be useful when organizing larger queues. Here are some things that i have noticed that should be changed:
Apart from that, i am not sure if the 'move to top' and 'move to bottom' buttons should be placed in the context menu of the queue item in the main screen. Since this action is moving an item in the queue, the 'organize queue' screen might be a better place for this action. But perhaps this would make the feature too difficult to find and use? |
Ah, didn't realize there was that restriction (and I probably didn't fully understand what context everything was executing in anyways). I'll make those changes. For button placement: my workflow is basically:
Putting the buttons on the context menu make that workflow faster (don't have to change modes). Of course, I originally found the organize queue method a little difficult to find, so it would probably be hard for people to find the move top/bottom there as well. Perhaps there's something else that could be done to make it more discoverable/easier to access (in the future). |
* created a helper function (moveQueueItemHelper) that does all the moving * Updated moveQueueItemToTop and moveQueueItemToBottom to use the helper function while using the ExecutorService * Updated moveQueueItem to use the helper function as well.
I've made the changes you suggested. Let me know if there's anything else. |
I can see your point about the accessability of the "organize queue" screen. The only reason why i have created it in the first place was that there is no drag & drop for ExpandableListViews, so i had to create this extra screen with a normal ListView. In the long run, the "Organize Queue" screen should be removed. Your changes work quite well, but there are two more things that should be changed in my opinion:
I'd suggest taking a look at the onCreateContextMenu-method in the EpisodesFragment in case you want to implement these changes. If you add the menu items in this method (instead of FeedItemMenuHandler) and check if the selected FeedItem is in the queue, it should work as described above. |
Ah, you're right of course. I didn't realize it was occurring in those places. I'll make the changes you suggest. |
…temMenuHandler so that we can ensure the user was actually in the 'Queue' dropdown when they opened the menu. Also, move to top now only shows up if the item isn't already at the top, similarly, for move to bottom, it only shows up if the item isn't already at the bottom.
Ok, I've made the changes. It also doesn't show move to top/bottom if it's already at the top/bottom. Not sure what you think generally about using helper functions or fixing spacing issues when they're encountered. I tried to keep my changes minimal. Let me know if there's anything else. |
Works perfectly! I have merged your changes into develop. There was a minor issue that i have fixed: In moveQueueItem you called moveQueueItem again instead of moveQueueItemHelper. |
Ahck, that was a dumb mistake. Thanks for merging it and making such a cool Written on a tiny keyboard.
|
Could this new API be used for sorting Audio/Video to top/bottom? The functionality I have implemented (see #192) in my fork is no more applicable in 0.9.7.5. |
This changes adds the menu options 'Move to top' and 'Move to bottom' to items in the Episode queue. This change enhances usability by making it easier to quickly change what you will (or won't) be listening to yet.
Let me know if any changes are needed.