Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig for code style consistency #244

Merged
merged 1 commit into from
May 18, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 14, 2023

No description provided.

@ByteHamster
Copy link
Member

Before reformatting files, I think we should have a CI check that enforces the formatting. Otherwise the files will soon be inconsistent again

.editorconfig Outdated Show resolved Hide resolved
@Rotzbua
Copy link
Contributor Author

Rotzbua commented May 14, 2023

Before reformatting files[..]

I removed the commit which formats some files from this PR to avoid conflict with other PRs. Formatting the files can be done by you so it does not require extra review.

I think we should have a CI check that enforces the formatting.

I never used a lint tool for editorconfig. Until now, I considered editorconfig to be an automatic text editor configuration rather than a strict style rule.
But I am open to new useful tools if they exist?

@ByteHamster ByteHamster merged commit f9fa154 into AntennaPod:master May 18, 2023
3 checks passed
@Rotzbua Rotzbua deleted the add_editorconfig branch May 18, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants