Bug fixes and button updates #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#49 allowTapping false not working has been fixed. And a new config key has been added 'marginOfError'. It is 10 default. marginOfError is amount of pixels the input can be from the thumb. #27 No step option has been fixed. There has always been a step option, just very broken logic. It has been fixed and the slider will now only update to closest step.
allowSliding will allow the user to slide in the direction of the slider for an amount of pixels and start sliding. This is in conjuction with allowTapping false so you can start sliding anywhere on the slider card and when you surpass the distance it will activate. slideDistance is the other new config key. This is default 10. It determines the amount of pixels the input has the travel for allowSliding to take effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fixes and major changes to my-button, so be aware of those when updating while using that card.
my-button has had an overhaul on the default styling. This might cause styling issues with users already using it and styling it. There might be more default styling that has to be changed by that custom styling as well now.
However, I think the default look of it is better, it is using theme colors as default now.
It also supports the switch entity now. slider is not shown as default for switches but can be toggled.
Related Issue
#49 fixed
#27 fixed
Motivation and Context
It solves the issues everyone is having with my-slider-v2 with step option. And adding new functionality that might be useful for some.
How Has This Been Tested
Extensively locally, but I don't have all the entity types to make sure the new changes work on fans and such.
Types of changes
Checklist