Integrate additional quality checks/linters/etc to repository.

[pktiuk]

I think it would make ensuring proper quality of our code easier.

It would be great if we would find also something what would help with tracking unused variables, libraries, unused elements of UI etc. (It would greatly help to hunt down unused code).

LIst of tools to check:

• Cmake
  • https://cmake-format.readthedocs.io/en/latest/cmake-lint.html
  • https://pypi.org/project/polysquare-cmake-linter/
  • https://pypi.org/project/cmakelint/
• C++
  • clang-tidy, scan-build
  • clazy
  • Cppcheck
  • https://www.sonarqube.org/
  • https://sonarcloud.io/
  • CodeQL: https://github.com/github/codeql-action #287
  • Add infer static code analysis to CI #289

[AriaMoradi]

It would be great if we would find also something what would help with tracking unused variables, libraries, unused elements of UI etc. (It would greatly help to hunt down unused code).

Probably some kind of tool exists that marks which parts of the code was executed and generates some kind of coverage report. I think visual studio has one...

It will be a long process of proofing and documenting though.

[pktiuk]

We have time.
But for now we should google and look after solutions.

[pktiuk]

I tried sonarcloud with fork of this repo https://sonarcloud.io/dashboard?id=testorgAntimictox_antimicrox

I think it could be an interesting lecture, but unluckily a big one.

[avinal]

I have looked into the options and I think we only need only a few types of code inspection/analysis tools.

• A static code analyzer
• A code format check
• DCO check(we should add it as a good open-source practice)
• Code Coverage check

We can choose best options or go for most used tools and then start adding them.

[pktiuk]

* A static code analyzer

I think this one would be very useful

* A code format check

We have already implemented code formatting check.

* DCO check(we should add it as a good open-source practice)

* Code Coverage check

We don't have any tests, so code coverage would be pointless

[avinal]

What about a DCO check?

[pktiuk]

What about a DCO check?

TBH

I don't think we need it.

[avinal]

I am going for CodeQl and infer for now. They seem simple yet effective and not very hard on CI either.

[pktiuk]

I think current tools are enough for now.