-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove qglobalshortcut #112
Conversation
I think this is done, unless we want to hunt down the unused code...(which was already plenty beforehand!) also after this is merged we can remove |
Thanks for setting this up! I'll take a deeper look on Friday. Let's wait 2 days for that maintainer... |
Can you test it like this? I removed most dead code. No bugs are caused. We can live with that 1 line left in user config |
Yeah it's likely because of the hidden stuff in #115. But I'll try to make it smaller. |
Merged, thanks @AriaMoradi for setting this up. |
Closes #106
well It built successfully and I opened and tested where "combination of keys for quitting app" is and it didn't crash after a restart and pressing of the set keys.
I think if we remove the ui, we could be done.
we probably can merge and deal with bugs caused by this later!