Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove qglobalshortcut #112

Merged
merged 7 commits into from
Dec 5, 2020
Merged

refactor: remove qglobalshortcut #112

merged 7 commits into from
Dec 5, 2020

Conversation

AriaMoradi
Copy link
Contributor

Closes #106

well It built successfully and I opened and tested where "combination of keys for quitting app" is and it didn't crash after a restart and pressing of the set keys.

I think if we remove the ui, we could be done.
we probably can merge and deal with bugs caused by this later!

@AriaMoradi AriaMoradi requested review from pktiuk and gombosg and removed request for pktiuk December 2, 2020 19:56
@AriaMoradi
Copy link
Contributor Author

screenshot_20201203_010715

now It looks like this, I did minimal deletions and just hid the element.

@AriaMoradi
Copy link
Contributor Author

AriaMoradi commented Dec 2, 2020

I think this is done, unless we want to hunt down the unused code...(which was already plenty beforehand!)

also after this is merged we can remove xcb from linked libraries.

@AriaMoradi AriaMoradi changed the title [WIP] remove qglobalshortcut remove qglobalshortcut Dec 2, 2020
@gombosg
Copy link
Collaborator

gombosg commented Dec 2, 2020

Thanks for setting this up! I'll take a deeper look on Friday. Let's wait 2 days for that maintainer...

@gombosg
Copy link
Collaborator

gombosg commented Dec 4, 2020

Can you test it like this? I removed most dead code. No bugs are caused. We can live with that 1 line left in user config .ini files.

@pktiuk
Copy link
Member

pktiuk commented Dec 4, 2020

Tested and everything works properly, but I would think about changing default size of settings window, It could be a bit smaller.

I think it looks better in this form.
image

@gombosg
Copy link
Collaborator

gombosg commented Dec 4, 2020

Yeah it's likely because of the hidden stuff in #115. But I'll try to make it smaller.

@gombosg gombosg changed the title remove qglobalshortcut refactor: remove qglobalshortcut Dec 5, 2020
@gombosg gombosg merged commit 4006ea9 into master Dec 5, 2020
@gombosg gombosg deleted the qglobalshortcut_removal branch December 5, 2020 20:46
@gombosg
Copy link
Collaborator

gombosg commented Dec 5, 2020

Merged, thanks @AriaMoradi for setting this up.

Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove qglobalshortcuts
3 participants