Cluster management pb fix #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- forking ct_slave because it cannot be configured as I want it to - now sets the working directory for slaves, so lager logs to the correct directory - standard output of slaves is written to the ct-log and to stio.log file, which should make debugging easier - protocol buffer process now also reports stacktrace to client
bieniusa
approved these changes
Jul 1, 2019
bieniusa
reviewed
Jul 1, 2019
remark: tests will fail, because erlang client needs similar fixes
Upgraded to lint v0.1.10 which is checking more things.
peterzeller
commented
Jul 4, 2019
…ee/antidote into cluster-management-pb-fix
peterzeller
commented
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unrelated changes, probably I should clean this up before merging.
fix createDc functioncommit fixes a bug we introduced in our last pull-request because we changed the registered name for that process.pb_client_cluster_management_SUITEis a new test for testing the cluster management. Apparently that is not tested at the moment. I still need to test joining 2 clusters. We should probably also add these functions to the Erlang client so that the test code is a bit nicer.The other changes change the testing framework, so that it is easier to debug.