Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix bug with standard emails sending #2

Merged

Conversation

cvinh
Copy link

@cvinh cvinh commented Nov 3, 2015

When installing mail_statistics_extras, we cannot send standard emails anymore

There was a typo, here is the fix

@rafaelbn
Copy link

rafaelbn commented Nov 3, 2015

cc @janetrp @antespi @JavierIniesta

@rafaelbn
Copy link

@antespi please review and update PR in OCA

@antespi
Copy link

antespi commented Nov 17, 2015

Thanks @invitu, good point!! ;)

antespi added a commit that referenced this pull request Nov 17, 2015
[FIX] fix bug with standard emails sending
@antespi antespi merged commit 04c434b into Antiun:pr-mail_statistics_extras Nov 17, 2015
@cvinh
Copy link
Author

cvinh commented Dec 23, 2015

Hello
I think that commit has not been merged with OCA/social branch...

rafaelbn added a commit to OCA/social that referenced this pull request Jan 4, 2016
fast-track of a fix from @invitu that we lost by error. Ref: Antiun#2
@rafaelbn
Copy link

rafaelbn commented Jan 4, 2016

Done. @antespi lost you change somewhere, sorry.

@cvinh
Copy link
Author

cvinh commented Jan 11, 2016

finally, the code has been rewritten
mail = super(MailMail, self).create(vals)

so you can return mail

@cvinh
Copy link
Author

cvinh commented Jan 11, 2016

I did a PR on OCA/social branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants