Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] mass_mailing_statistic_extra addon #19

Merged
merged 1 commit into from
Dec 14, 2015
Merged

[ADD] mass_mailing_statistic_extra addon #19

merged 1 commit into from
Dec 14, 2015

Conversation

antespi
Copy link
Contributor

@antespi antespi commented Oct 8, 2015

This module add extra info to mail statictics records:

  • email_from
  • email_to
  • subject

In order to give a more useful information to final user when listing email
statistics related with a mass mailing message

@janetrp
Copy link

janetrp commented Oct 27, 2015

Tested. Great improvement:+1:

rafaelbn
rafaelbn reviewed Oct 28, 2015
View reviewed changes
mail_statistics_extras/README.rst

Usage
=====

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to use it? Please @janetrp add it thanks

@janetrp
Copy link

janetrp commented Oct 28, 2015

@antespi you can add the usage now in Readme

@rafaelbn
Copy link
Member

rafaelbn commented Nov 3, 2015

This module has an issue, please check Antiun#2

@rafaelbn
Copy link
Member

@pedrobaeza please remove need fixing for need review, the issue has been solved. Thanks

@pedrobaeza
Copy link
Member

Well, the name should be put in singular

@rafaelbn
Copy link
Member

Tested in local 👍 great! thanks!

@hbrunn
Copy link
Member

hbrunn commented Nov 20, 2015

@antespi please add tests

@hbrunn hbrunn added the 8.0 label Nov 20, 2015
@yajo
Copy link
Member

yajo commented Nov 20, 2015

Seems quite good. Any reason for using v7 api?

@yajo
Copy link
Member

yajo commented Nov 20, 2015

Ah, and name should be mass_mailing_statistic_extra IMHO.

@hbrunn hbrunn added this to the 8.0 milestone Nov 25, 2015
@antespi
Copy link
Contributor Author

antespi commented Nov 27, 2015

@yajo, @hbrunn, @rafabn, @janetrp, @pedrobaeza
Today is OCA Addons Friday! 😄

  • Test added
  • Rebase and squash
  • Addon name changed

Thanks for review and happy weekend!

@antespi antespi changed the title [ADD] mail_statistics_extras addon [ADD] mass_mailing_statistic_extra addon Nov 27, 2015
@rafaelbn
Copy link
Member

Tested, already in all our customers's production environments! 👍
Please @pedrobaeza could you change label to need review? Thanks!

hbrunn
hbrunn reviewed Nov 27, 2015
View reviewed changes
mass_mailing_statistic_extra/models/mail_mail.py
# License AGPL-3: Antiun Ingenieria S.L. - Antonio Espinosa
# See README.rst file on addon root folder for more details

from openerp.osv import osv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import models

@antespi
Copy link
Contributor Author

antespi commented Dec 4, 2015

@yajo, @hbrunn, @rafabn we are here again and today is OCA Addon Friday! 😄

  • Migrated to api v8
  • Squashed and rebase
  • Test passed in local env

@antespi
Copy link
Contributor Author

antespi commented Dec 4, 2015

Runbot was killed. Who was it? 😄

@pedrobaeza
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Dec 14, 2015
@pedrobaeza
Merge pull request #19 from Antiun/pr-mail_statistics_extras
834ff5e 
[ADD] mass_mailing_statistic_extra addon
@pedrobaeza pedrobaeza merged commit 834ff5e into OCA:8.0 Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@antespi @janetrp @rafaelbn @pedrobaeza @hbrunn @yajo @nhomar