Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comments based on best practices from Effective Go #10

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

CodeLingoBot
Copy link
Contributor

Signed-off-by: CodeLingo Bot bot@codelingo.io

Signed-off-by: CodeLingo Bot <bot@codelingo.io>
@mullikine
Copy link

Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name being declared.
From effective go.

I generated this with CodeLingo and I'm keen to get some feedback, but this is automated so feel free to close it and just say "opt out" to opt out of future CodeLingo outreach PRs.

@mullikine
Copy link

I have triple checked this PR to make sure the bot has done its job of correctly fixing incorrect doc comments without introducing any false positives.

If this service is useful to you, please let me know 😄

Note: I've only updated functions that I know CodeLingo can rewrite nicely, but you can install it from the GitHub marketplace to review your PRs automatically and find all issues.

@AntoineAugusti
Copy link
Owner

Thanks!

@AntoineAugusti AntoineAugusti merged commit 30135e4 into AntoineAugusti:master Feb 20, 2019
@Daanikus Daanikus mentioned this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants