🐛 corret merge stats' start and end date #38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 29 37 +8
Branches 1 1
=========================================
+ Hits 29 37 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hey @stormslowly!
Thank you for this improvement.
Just one small question:
lib/index.js
Outdated
| ) | ||
| return { start, end } | ||
| }, | ||
| { ...spans[0] } |
There was a problem hiding this comment.
Why do you need a spread here? I think, here it’s possible to reduce without supplying the initial value at all
There was a problem hiding this comment.
yes, it can be removed
|
@Antontelesh @stormslowly any updates here? Would love to get this merged. I am trying to generate dashboard and correct values in stats in final merge report will be helpful :). Thanks |
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@Antontelesh thx a lot for your comment, learn the reduce API again ~ |
as the title