-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax error when updating grub if a snapshot name contains one single quote #198
Comments
Hi, when you ran I probably just gonna add a function to sanitize the snapshot names and run every snapshot though it. |
I got the same syntax error messages when running grub-mkconfig, and the snapshot submenu of GRUB was empty. Both issues went away after removing the single quotation mark (possessive apostrophe, actually) in the description field of one of my Timeshift snapshots. I look forward to Schievel1's fix, but avoiding a single quotation mark/apostrophe in the description works for now. Thanks! |
I created a really small sanitize function. https://github.com/Antynea/grub-btrfs/pull/226/files#diff-9b6d1a434bd2a223bf71bbbb1393b35e131311e2a8369779c6be2a116626630fR165 I think we can not really do much other than sanitizing the string we return up to grub-mkconfig. This is grub-mkconfig which throws that error if I am not mistaken. |
Closes #198 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
I only encountered problems with the apostrophe. I suspect it causes an imbalance in the single quotes which confuses the syntax checker. Thanks for dealing with this. |
I am only sanitizing the menu titles, which seems to be enough for when there is a ' in the comment of a snapshot. This is more or less a note to myself to try that out, but you can give that a try as well if you want to. |
Turns out in Timeshift you can not alter the snapshot names, its always the date. So no way to get a I think this is the same for snapper, isn't it? I just checked and there is only a way to provide a description, not a name for the snapshot. |
Closes #198 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Closes #198 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
I found that removing the single quote fixes it, and it does not occur when there are two single quotes.
Version: 4.1.1
Distro: Manjaro
The text was updated successfully, but these errors were encountered: