Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Make sure make is invoked with appropriate permissions #146

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

bdaase
Copy link
Contributor

@bdaase bdaase commented Feb 28, 2021

No description provided.

@Antynea
Copy link
Owner

Antynea commented Mar 1, 2021

Good catch, thank you for your contribution !

@Antynea Antynea merged commit 3433754 into Antynea:master Mar 1, 2021
@sgn
Copy link

sgn commented Apr 14, 2021

Hello,
But I think this change is not that necessary:

  • In case someone wants to install into system directories directly, they'll be complaint as insufficient permission anyway.
  • For those distros, that would like to install into $(DESTDIR), this change requires us to either add fakeroot to package's build-depends, or revert this one out :(

@Antynea
Copy link
Owner

Antynea commented Apr 19, 2021

Hello @sgn ,

I understand your arguments,
do you want the commit to be cancelled ?
or
do you want to propose your own fix ?

@sgn
Copy link

sgn commented May 7, 2021

I think this change should be reverted, or partial reverted.

While I think make install shouldn't care about the UID, I don't have any strong opinons for make uninstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants