Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translations #9140

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

phinner
Copy link
Contributor

@phinner phinner commented Oct 6, 2023

Hon Hon Hon, I have updated the french translations.
But I am having difficulties with the new unit system.

Basically the words "Unit Stance" and "Unit Command", both involve movement while the closest translation of stance in French is "position", which implies no movement.
This confused me so I translated stance to "Order", but it is a direct synonym of "Command". This is not an ideal translation so maybe you could clarify the intent between the 2 sets of unit commands (command and stance) 馃.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Copy link
Contributor

@VizardAlpha VizardAlpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good

@phinner phinner marked this pull request as ready for review October 16, 2023 21:11
# Conflicts:
#	core/assets/bundles/bundle_fr.properties
@phinner
Copy link
Contributor Author

phinner commented Nov 13, 2023

馃 Merge pls.

@Anuken Anuken merged commit d259554 into Anuken:master Nov 13, 2023
1 check passed
@phinner phinner deleted the chore/update-french-translations branch November 13, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants