-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French translations #9140
Merged
Anuken
merged 9 commits into
Anuken:master
from
phinner:chore/update-french-translations
Nov 13, 2023
Merged
Update French translations #9140
Anuken
merged 9 commits into
Anuken:master
from
phinner:chore/update-french-translations
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix fpr translate to bagette language --------- Co-authored-by: Phinner <62483793+phinner@users.noreply.github.com>
VizardAlpha
reviewed
Oct 13, 2023
VizardAlpha
reviewed
Oct 13, 2023
VizardAlpha
reviewed
Oct 13, 2023
VizardAlpha
reviewed
Oct 14, 2023
VizardAlpha
reviewed
Oct 14, 2023
VizardAlpha
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good
# Conflicts: # core/assets/bundles/bundle_fr.properties
馃 Merge pls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hon Hon Hon, I have updated the french translations.
But I am having difficulties with the new unit system.
Basically the words "Unit Stance" and "Unit Command", both involve movement while the closest translation of stance in French is "position", which implies no movement.
This confused me so I translated stance to "Order", but it is a direct synonym of "Command". This is not an ideal translation so maybe you could clarify the intent between the 2 sets of unit commands (command and stance) 馃.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: