Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trunk): Fixed penetration warning for the pectoralis #939

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

melund
Copy link
Member

@melund melund commented Apr 4, 2024

Fixed a penetration warnings for the pectoralis muscles when the thoracic segments is scale very non-uniformly.
The fix involves a small (5 deg) adjustments to the orientation of the pectoralis wrapping surface.

The small adjustments  in the orientation of the pectoralis wrapping surface orientation prevents wrapping penetrations problems in more extreme scaling situatins where the thoracic segment is not scaled uniformly.
@github-actions github-actions bot added the fix label Apr 4, 2024
@melund melund requested review from toerholm and mdabt April 4, 2024 14:47
@melund melund requested a review from bkje14 April 9, 2024 09:07
bkje14
bkje14 previously approved these changes Apr 9, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@melund melund changed the title fix(trunk): Fixed a penetration warnings for the pectoralis fix(trunk): Fixed penetration warning for the pectoralis Apr 10, 2024
melund and others added 2 commits April 11, 2024 13:05
Co-authored-by: bkje14 <42773361+bkje14@users.noreply.github.com>
Signed-off-by: Morten Enemark Lund <melund@gmail.com>
Signed-off-by: Morten Enemark Lund <mel@anybodytech.com>
@melund melund merged commit 321ff21 into master Apr 11, 2024
@melund melund deleted the pectoralis-wrap-adjustment branch April 11, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants