feat: add arbitrum #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/fix kofi branch
fubuloubu
approved these changes
Jun 21, 2022
|
Need to mock EcosystemAPI and run |
fubuloubu
approved these changes
Jun 24, 2022
fubuloubu
approved these changes
Jun 24, 2022
added 2 commits
June 25, 2022 22:12
fubuloubu
approved these changes
Jun 25, 2022
fubuloubu
reviewed
Jun 25, 2022
tests/test_providers.py
Outdated
| @@ -44,6 +44,8 @@ def token(mocker): | |||
| def mock_network(mocker): | |||
| mock = mocker.MagicMock(spec=NetworkAPI) | |||
| mock.name = "MOCK_NETWORK" | |||
| mock.ecosystem = mocker.MagicMock(spec=EcosystemAPI) | |||
| mock.ecosystem.name = "MOCK_ECOSYSTEM" | |||
There was a problem hiding this comment.
Seems like this should replicate a real ecosystem name?
There was a problem hiding this comment.
I dont think it really matters but you could
There was a problem hiding this comment.
oh yeah that is why the tests are failing, so yeah make this real
antazoey
approved these changes
Jun 26, 2022
fubuloubu
approved these changes
Jun 26, 2022
4 tasks
fubuloubu
added a commit
to ApeWorX/ape-arbitrum
that referenced
this pull request
Apr 20, 2023
Was already merged in ApeWorX/ape-alchemy#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
feat: Add Arbitrum support to ape-alchemy
How I did it
How to verify it
Checklist