Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: new flow [APE-1140] #11

Merged
merged 135 commits into from
Dec 22, 2023
Merged

refactor!: new flow [APE-1140] #11

merged 135 commits into from
Dec 22, 2023

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Jun 28, 2023

What I did

Adds support for leveraging the Safe API to publish transactions, confirmations, and fetch confirmations to submit pending transactions

How I did it

How to verify it

Checklist

  • Validate this works on testnet safe
  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat: integrate confirmations with safe api feat: integrate confirmations with safe api [APE-1140] Jun 28, 2023
@linear
Copy link

linear bot commented Jun 28, 2023

APE-1140 "feat: integrate confirmations with safe api" (ApeWorX/ape-safe #11)

What I did

Adds support for leveraging the Safe API to publish transactions, confirmations, and fetch confirmations to submit pending transactions

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ApeWorX/ape-safe #11 by fubuloubu on GitHub

via LinearSync

@fubuloubu fubuloubu marked this pull request as draft June 28, 2023 16:04
ape_safe/client.py Outdated Show resolved Hide resolved
ape_safe/accounts.py Show resolved Hide resolved
@banteg
Copy link
Contributor

banteg commented Jul 4, 2023

still encountering problems when trying to submit a multisend tx. they are mostly coming from gas estimation:

  • prepare_transaction tries to estimate gas from a safe address
    • it fails when the safe has no ether to cover the gas costs, but in reality safe itself never pays for gas
    • it fails because it tries to estimate a call to the multisend contract, while it only supports delegatecall

we need to somehow override the tx handler or find a way to pass additional metadata to skip some checks

@fubuloubu
Copy link
Member Author

@banteg for this PR, @dtdang is gonna focus on making sure it works against the Goerli SafeAPI and finish up by documenting as much of the new functionality as possible, so we can get this merged and move on to the other bug fixes needed

@antazoey antazoey changed the title feat: integrate confirmations with safe api [APE-1140] refactor!: re-write of most things [APE-1140] Dec 11, 2023
@antazoey antazoey changed the title refactor!: re-write of most things [APE-1140] refactor!: new flow [APE-1140] Dec 11, 2023
@antazoey
Copy link
Member

type checking will fail until ApeWorX/ape#1793 is released

@antazoey antazoey merged commit e3a3a0e into main Dec 22, 2023
24 checks passed
@antazoey antazoey deleted the feat/safe-api branch December 22, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants