feat: add gas limit configuration #1009
Conversation
|
Need to add project tests still which is a WIP, I know I'll at least be adding in functional tests that configure a project with a gas limit and then manually call |
ghost
marked this pull request as ready for review
| eth_config = config.get_config("ethereum") | ||
|
|
||
| assert eth_config.rinkeby.gas_limit == "auto" | ||
| assert eth_config.local.gas_limit == "auto" |
There was a problem hiding this comment.
In 0.6 or any future release, we may want to consider making max the default for local.
I think it will give speed improvements to running test suites.
There was a problem hiding this comment.
Good point, and what's funny is I thought previously I had local set to max but I can't seem to find trace of that now 🤔 it was before that pre-audit work so I think I lost a bit of track with the gear switching
I may need to revisit this for #957 but I'll see about including such changes in that PR if need be 👍
There was a problem hiding this comment.
If we want to make it use max now, that is probably fine. It should not affect anything really so maybe not a real breaking change
Co-authored-by: Juliya Smith <yingthi@live.com>
Co-authored-by: Juliya Smith <yingthi@live.com>
Co-authored-by: Juliya Smith <yingthi@live.com>
Co-authored-by: Juliya Smith <yingthi@live.com>
Co-authored-by: Juliya Smith <yingthi@live.com>
Co-authored-by: Juliya Smith <yingthi@live.com>
What I did
fixes: #985
Added
gas_limitas an available parameter forNetworkConfig(and subsequentlyNetworkAPI)How to verify it
WIP
Checklist