Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gas limit configuration #1009
feat: add gas limit configuration #1009
Changes from all commits
63f9d16
930c86d
2c88d18
b96572f
2e8b2a1
80e3a21
5a350f5
320c165
56dd5a7
29a917a
4c502af
88688b1
a2c219e
dc90483
7685ffc
f2aba77
324d04c
e002111
a065de5
46e51aa
df6616d
27302b6
3d9690d
a7c8a09
d0f687c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 0.6 or any future release, we may want to consider making
max
the default forlocal
.I think it will give speed improvements to running test suites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, and what's funny is I thought previously I had local set to
max
but I can't seem to find trace of that now 🤔 it was before that pre-audit work so I think I lost a bit of track with the gear switchingI may need to revisit this for #957 but I'll see about including such changes in that PR if need be 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to make it use max now, that is probably fine. It should not affect anything really so maybe not a real breaking change