Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with pattern matching for source file exclusions #2081

Merged
merged 6 commits into from
May 9, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 9, 2024

What I did

finally think i got this....

  • issue where couldnt match by solid name

basically fixes an issue where if you change contracts folder and your build is now somewhere it else, it my start "compiling"... so this adjusts the exclusions so it's always excluded, how it was before

How I did it

  • make a helper method to handle and share and do this

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title fix: issues with pattern matching fix: issues with pattern matching for source file exclusions May 9, 2024
@antazoey antazoey requested a review from mikeshultz May 9, 2024 15:05
@antazoey antazoey enabled auto-merge (squash) May 9, 2024 15:18
@antazoey antazoey merged commit d2cdb0d into ApeWorX:main May 9, 2024
17 checks passed
@antazoey antazoey deleted the fix/build-exc branch May 9, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants