APERTA-11767 Downgrade Ember-data from 2.12.2 to 2.11.3 #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Data 2.12 introduced a bug which prevents destroys and saves happening within the same run loop. We had originally updated Ember to 2.13 and then found this issue when testing repeaters which routinely destroy and save within the same run loop, thus exposing the problem. Since this bug is subtle and may be present in unknown places elsewhere in the codebase, it was determined that downgrading to 2.11.* makes the most sense as a temporary fix until the project can eventually be updated to the latest version of Ember Data. We originally attempted upgrading to several NEWER version of Ember Data (instead of downgrading), but there were many other test failures that showed up and not enough time to fix the root causes, so this is a sensible temporary fix. bug introduced = emberjs/data#4668 bug reported = emberjs/data#4993 bug fixed = emberjs/data#4994
surfacedamage
changed the title
ceautery
changed the title
|
Looks like the correct ED version in the review app:
I gather that there's no know way to reproduce this bug on master, but I'll do some clicking around in the review app to make sure nothing is obviously broken. So far this all looks good! Thanks for whipping this PR together so quickly @surfacedamage. |
JackLaBarba
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://jira.plos.org/jira/browse/APERTA-11767
What this PR does:
Ember Data 2.12 introduced a bug which prevents destroys and saves
happening within the same run loop. We had originally updated Ember to
2.13 and then found this issue when testing repeaters which routinely
destroy and save within the same run loop, thus exposing the problem.
Since this bug is subtle and may be present in unknown places elsewhere
in the codebase, it was determined that downgrading to 2.11.* makes the
most sense as a temporary fix until the project can eventually be updated
to the latest version of Ember Data.
We originally attempted upgrading to several NEWER version of Ember Data
(instead of downgrading), but there were many other test failures that
showed up and not enough time to fix the root causes, so this is a
sensible temporary fix.
bug introduced = emberjs/data#4668
bug reported = emberjs/data#4993
bug fixed = emberjs/data#4994
Special instructions for Review or PO:
This is a regression level test.
Code Review Tasks:
Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):
Reviewer tasks (these should be checked or somehow noted before passing on to PO):