Main #33
Merged
Main #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#15002) * update decode-uri-component transitive dep to 0.2.2 by @paninaro in Chia-Network/chia-blockchain-gui#1662 * bump webpack to 5.77.0 to address a dependabot alert by @paninaro in Chia-Network/chia-blockchain-gui#1660 * NFT Provider - refactored NFTs by @seeden in Chia-Network/chia-blockchain-gui#1651 * GUI: Add option to Emoji picker to clear or not set an emoji by @rifeljm in Chia-Network/chia-blockchain-gui#1666 * GUI: Make URL values in NFTProperties clickable by @rifeljm in Chia-Network/chia-blockchain-gui#1668 * Temporary workaround issue using openDialog() on WalletConnect dialogs. by @paninaro in Chia-Network/chia-blockchain-gui#1670 **Full Changelog**: Chia-Network/chia-blockchain-gui@1.8.0-b4...1.8.0-b5
…(#14831) * add new peak and tidy new compact vdf limited semaphore full logging * log the peer as well * delayed formatting for debug logging * -f
…) (#14932) <!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: It's unnecessary to have the same create_tandem_xch_tx method in different wallets. <!-- Does this PR introduce a breaking change? --> ### Current Behavior: Each wallet its own create_tandem_xch_tx ### New Behavior: Share the create_tandem_xch_tx in the standard wallet, unless the wallet needs to override, like CAT wallet. <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
… a PR (#14070) ## What is the purpose of the changes in this PR? There was an issue where actual conflict status and label did not match. Chia-Network/chia-blockchain#14052 https://github.com/Chia-Network/chia-blockchain/actions/runs/3631834598/jobs/6126986602#step:2:182 The mismatch seems to be happened because the `label-conflict` action did not run after the conflict resolved. ## What is the current behavior? `label-conflict` action does not run when PR from forked branch is opened/reopened. ## What is the new behavior (if this is a feature change)? `label-conflict` action does run when PR from forked branch is opened/reopened. ## Does this PR introduce a breaking change? No ## Testing notes (is this code covered by tests, or equivalent manual testing?) In the workflow jobs in this PR, there is not a `label-conflict` action on `pull_request_target` context. (Only `label-conflict` action of `push` to `main` ran but it seems the action of push context does not run for forked PR) <!-- Are there any visual examples to help explain this PR? (attach any .gif/movie/console output below) -->
Bumps [Apple-Actions/import-codesign-certs](https://github.com/Apple-Actions/import-codesign-certs) from 1 to 2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Apple-Actions/import-codesign-certs/releases">Apple-Actions/import-codesign-certs's releases</a>.</em></p> <blockquote> <h2>v1.0.2</h2> <p>Fixes p12 file encoding issue.</p> <h2>v1.0.1</h2> <p>Adds a new option to get the Signing Certificates from a Base64 encoded string (such as a repo secret).</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/8f3fb608891dd2244cdab3d69cd68c0d37a7fe93"><code>8f3fb60</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/41">#41</a> from ssrobins/v2</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/357d43ebbd7cce8f7202c76db5d99c1ae29bd79f"><code>357d43e</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/47">#47</a> from Apple-Actions/dependabot/npm_and_yarn/minimatch-3...</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/8396641780d304fc65e33174eaa59784591e53e8"><code>8396641</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/45">#45</a> from GiddyGoatGaming/patch-1</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/a648e17db806e1b89a3c3ef719cd35ba72538f00"><code>a648e17</code></a> Bump minimatch from 3.0.4 to 3.1.2</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/6a11927fbd9bd765f4c03f49524e8c7ac98b6dd0"><code>6a11927</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/43">#43</a> from Apple-Actions/dependabot/npm_and_yarn/qs-6.5.3</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/01ef787aa7281f658d77360d606f07b4d5bca5d9"><code>01ef787</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/42">#42</a> from Apple-Actions/dependabot/npm_and_yarn/decode-uri-...</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/63502f2ddf7a7abf14d17a72f4b1c9c6192033a4"><code>63502f2</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/39">#39</a> from Apple-Actions/dependabot/npm_and_yarn/kind-of-6.0.3</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/896b19008088b4dc5b44f58c4515fb225b4dfa9d"><code>896b190</code></a> Merge pull request <a href="https://redirect.github.com/Apple-Actions/import-codesign-certs/issues/44">#44</a> from Apple-Actions/dependabot/npm_and_yarn/json5-2.2.3</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/6861374cc98d96e8ef611c9ff659d00c9d16f9c7"><code>6861374</code></a> test: bump checkout to v3</li> <li><a href="https://github.com/Apple-Actions/import-codesign-certs/commit/ff91926c74f68662ea2c41d958a4e7bae7e24cda"><code>ff91926</code></a> Bump json5 from 2.1.1 to 2.2.3</li> <li>Additional commits viewable in <a href="https://github.com/Apple-Actions/import-codesign-certs/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: Code cleanup <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 1 to 2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws-actions/configure-aws-credentials/releases">aws-actions/configure-aws-credentials's releases</a>.</em></p> <blockquote> <h2>v2</h2> <p>This tag tracks the latest v2.x.x release.</p> <h2>v2.0.0</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/v2.0.0/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.7.0</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.6.1</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.6.0</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.11</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.10</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.9</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.8</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.7</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.6</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.5</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.4</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.3</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.2</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.1</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <h2>v1.5.0</h2> <p>See the <a href="https://github.com/aws-actions/configure-aws-credentials/blob/HEAD/CHANGELOG.md">changelog</a> for details about the changes included in this release.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md">aws-actions/configure-aws-credentials's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws-actions/configure-aws-credentials/compare/v1.7.0...v2.0.0">2.0.0</a> (2023-03-06)</h2> <h3>Features</h3> <ul> <li>Version bump to use Node 16 by default.</li> </ul> <h2><a href="https://github.com/aws-actions/configure-aws-credentials/compare/v1.6.1...v1.7.0">1.7.0</a> (2022-08-03)</h2> <h3>Features</h3> <ul> <li>Allow audience to be explicitly specified (<a href="https://github.com/aws-actions/configure-aws-credentials/commit/2f8dfd0ed43d880f85b57f0c8727b497af2037de">2f8dfd0</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/e1e17a757e536f70e52b5a12b2e8d1d1c60e04ef"><code>e1e17a7</code></a> Version 2 release (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/685">#685</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/bab55d3830fe69833c9fecaa51fe2c829a7508f3"><code>bab55d3</code></a> chore: Bump axios from 1.3.3 to 1.3.4 (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/679">#679</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/07b737a14fc628c3cb8b99a172b150fdea376d25"><code>07b737a</code></a> chore: Update dist</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/26e4efa71fbc395226c359bd3f2d5fdd38d9af85"><code>26e4efa</code></a> chore: Bump aws-sdk from 2.1320.0 to 2.1324.0 (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/677">#677</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/7e0ecf0346f0dff6db9c0bfc56f459e938888730"><code>7e0ecf0</code></a> chore: Bump eslint from 8.34.0 to 8.35.0 (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/675">#675</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/567d4149d67f15f52b09796bea6573fc32952783"><code>567d414</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/563">#563</a> from russau/docs/readme-role-update</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/32eb1b4a6692b0a851328355719189b79118a174"><code>32eb1b4</code></a> feat: document mask-aws-account-id input (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/606">#606</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/6ca257764313f33f44efb3df7a3e27b3e67f35c7"><code>6ca2577</code></a> chore: Update dist</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/f1de0761358f06cb7dd99ed4830a5a20cb1b00e5"><code>f1de076</code></a> chore: Bump aws-sdk from 2.1273.0 to 2.1320.0 (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/666">#666</a>)</li> <li><a href="https://github.com/aws-actions/configure-aws-credentials/commit/077fd1fc8f6f9674559d1d11e69e78d182cb5b9f"><code>077fd1f</code></a> chore: Bump jest from 29.4.2 to 29.4.3 (<a href="https://github-redirect.dependabot.com/aws-actions/configure-aws-credentials/issues/663">#663</a>)</li> <li>Additional commits viewable in <a href="https://github.com/aws-actions/configure-aws-credentials/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
…d add tests (#14626) Refactor function `is_trusted_peer` to a standalone easily testable function. Leverage the existing `is_localhost` function to extend coverage to IPv6 local address for the trusted peer check Added tests for the new standalone function
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: self.new_subslot_end is not currently used. clean up to make code cleaner <!-- Does this PR introduce a breaking change? --> ### Current Behavior: Same behavior ### New Behavior: Same behavior <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: No change in behavior. Code is the same. <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: Make it so `python -m chia` works. This makes it easier to subprocess such as `subprocess.run([sys.executable, "-m", "chia"], check=True)` when we need to. <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
…e batch queue (#14804) <!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: Please weigh in on whether this should be applied to the release or retargeted to main. The `finally:` clause will already result in `None` being put into the queue. I expect that the other `None` pushed before the `return` is unnecessarily doubling this up. I don't know if the double `None` has any negative effect. <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
…_daemon() (#14867) <!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: As is this would not close the daemon if a BaseException were raised. For example `KeyboardInterrupt` or `asyncio.CancelledError` (on 3.8+). <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->
### Purpose:
Self connection errors don't need to be `ERROR` level in the log nor do
they need to have tracebacks. This will mostly happen when a node is
unaware of one or more of its own public IPs being used by the network.
Could be IPv4 vs. IPv6, or multiple IPs, or just being behind a NAT.
<!-- Does this PR introduce a breaking change? -->
### Current Behavior:
```python-traceback
2023-03-22T14:00:46.076 full_node full_node_server : ERROR Exception Trying to connect to a peer (PeerInfo(_ip=IPv4Address('<REDACTED>'), _port=58445)) with the same peer_id: <REDACTED>, exception Stack: Traceback (most recent call last):
File "/home/ubuntu/chia-blockchain/chia/server/server.py", line 525, in start_client
raise RuntimeError(f"Trying to connect to a peer ({target_node}) with the same peer_id: {peer_id}")
RuntimeError: Trying to connect to a peer (PeerInfo(_ip=IPv4Address('<REDACTED>'), _port=58445)) with the same peer_id: <REDACTED>
```
### New Behavior:
`INFO` level logging without a traceback
<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->
### Testing Notes:
<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: remove dead code so the remaining code is more comprehensible <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
Sometimes, you might get output from CI like this: ``` > Run mypy chia/wallet/puzzle_drivers.py:107: error: Unused "type: ignore" comment chia/wallet/puzzles/prefarm/make_prefarm_ph.py:32: error: Unused "type: ignore" comment tests/wallet/nft_wallet/test_ownership_outer_puzzle.py:24: error: Unused "type: ignore" comment tests/core/util/test_streamable.py:658: error: Unused "type: ignore" comment Found 4 errors in 4 files (checked 753 source files) ``` You might be confused, because `pre-commit` ran fine on YOUR machine. "Why didn't it lint check clean in CI?", I hear you wonder. Obviously, this has never happened to me. However, just in case you know someone if has happened to, this one's for you. Changes CI output only.
Testing the install scripts on Linux Mint has very little value and simply causes longer CI times along with more chances of flaky failure due to network issues during OS setup. We are transitioning away from users running the install manually to more and more encouraging users to use the binary packages and Mint users can use the Ubuntu DEB package. This distro is only minimally popular and there is no rationale for specific testing on Mint as opposed to other distros (Gentoo, etc)
* Add new coin_type & metadata to coin_records * Remove unrelated changes * Fix pre-commit * Remove unrelated changes * Fix pre-commit * Add get_coin_records_between * Fix field data type * Resolve comments * Fix unit test * Remove unrelated changes * Remove unrelated changes
* generic downloader * add s3 Downloader * tests * pre commit * create uploader protocol, factor out upload code * fix pre commit * add s3 uploader * add add helper for testing with real bucket * typing * lint * logs * start service separation * working aiohttp s3 service * lint * multiple instances config * break if failed to write * better error handling * update from conf before checking * lint * redundant config * also update bucket * improve exception handling * remove old tests * uae multiple uploaders * Update chia/data_layer/data_layer.py pr comments Co-authored-by: Kyle Altendorf <sda@fstab.net> * pr comments * Apply typos fixes from code review Co-authored-by: Kyle Altendorf <sda@fstab.net> * Update chia/data_layer/s3_plugin_service.py Co-authored-by: Kyle Altendorf <sda@fstab.net> * scheme in conf * use byte32 for store_ids list * use dataclass instead of tuple for return value * initial config handling for uploaders and downloaders --------- Co-authored-by: Kyle Altendorf <sda@fstab.net> Co-authored-by: Earle Lowe <30607889+emlowe@users.noreply.github.com> Co-authored-by: Earle Lowe <e.lowe@chia.net>
* Rename singleton helper functions * Amend abbreviation in Singleton Puzzle creation functions
* Drop unused `List[SubEpochSummary]` return * Drop unused `SubEpochSummary` return * Raise in `WalletWeightProofHandler.validate_weight_proof` * Move validation logs * Set the new weight proof inside `fetch_and_update_weight_proof` Which was `fetch_and_validate_the_weight_proof` before. * Drop `WalletWeightProofHandler._weight_proof_tasks`, just await them Doesn't seem to make a lot sense to have a list of tasks where we always just add a task, await it and remove it after. This happens in the long sync so to parent task will cancel the awaited task anyway.
…inux (#14489) Bump http-cache-semantics in /build_scripts/npm_linux Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…indows (#14486) Bump http-cache-semantics in /build_scripts/npm_windows Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…acos (#14485) Bump http-cache-semantics in /build_scripts/npm_macos Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Adding 1.8.1 changelog * Update CHANGELOG.md * removing extra draft info * spelling --------- Co-authored-by: Earle Lowe <30607889+emlowe@users.noreply.github.com>
Source hash: 1c5b4a1 Remaining commits: 0
…m_macos (#15322) build(deps): bump minimatch and electron-builder Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.2 and updates ancestor dependency [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder). These dependencies need to be updated together. Updates `minimatch` from 3.0.4 to 3.1.2 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) Updates `electron-builder` from 23.5.1 to 24.4.0 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/v24.4.0/packages/electron-builder) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect - dependency-name: electron-builder dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…m_linux (#15321) build(deps): bump minimatch and electron-builder Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.2 and updates ancestor dependency [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder). These dependencies need to be updated together. Updates `minimatch` from 3.0.4 to 3.1.2 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) Updates `electron-builder` from 23.5.1 to 24.4.0 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/v24.4.0/packages/electron-builder) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect - dependency-name: electron-builder dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nt/main_from_release_1.8.1_c61129d3b10abd4128cd6f99bdcf8dd08ff116d0
Source hash: c61129d Remaining commits: 0
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Enable signing for PRs that have secret access * Add CSC_FOR_PULL_REQUEST var as well
* remove softfork-logic for 1.7 softfork (which has already activated) * add new constants for soft-fork3, hard-fork and the other plot-filter adjustments
…` (#15330) * server: Store `Version` objects instead of `str` in `WSChiaConnection` * Test connection versions
Bumps [watchdog](https://github.com/gorakhargosh/watchdog) from 2.2.0 to 3.0.0. - [Release notes](https://github.com/gorakhargosh/watchdog/releases) - [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst) - [Commits](gorakhargosh/watchdog@v2.2.0...v3.0.0) --- updated-dependencies: - dependency-name: watchdog dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [typing-extensions](https://github.com/python/typing_extensions) from 4.5.0 to 4.7.1. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.5.0...4.7.1) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…-3.0.0 Bump watchdog from 2.2.0 to 3.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ain-actions-checkout-4 Bump actions/checkout from 3 to 4
Bumps [dnspython](https://github.com/rthalley/dnspython) from 2.3.0 to 2.4.2. - [Release notes](https://github.com/rthalley/dnspython/releases) - [Changelog](https://github.com/rthalley/dnspython/blob/master/doc/whatsnew.rst) - [Commits](rthalley/dnspython@v2.3.0...v2.4.2) --- updated-dependencies: - dependency-name: dnspython dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [blspy](https://github.com/Chia-Network/bls-signatures) from 1.0.16 to 2.0.2. - [Release notes](https://github.com/Chia-Network/bls-signatures/releases) - [Commits](Chia-Network/bls-signatures@1.0.16...2.0.2) --- updated-dependencies: - dependency-name: blspy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 2 to 4. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v2...v4) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.4 to 3.8.6. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.8.4...v3.8.6) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [chiapos](https://github.com/Chia-Network/chiapos) from 1.0.11 to 2.0.3. - [Release notes](https://github.com/Chia-Network/chiapos/releases) - [Commits](Chia-Network/chiapos@1.0.11...2.0.3) --- updated-dependencies: - dependency-name: chiapos dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [chia-rs](https://github.com/Chia-Network/chia_rs) from 0.2.7 to 0.2.11. - [Release notes](https://github.com/Chia-Network/chia_rs/releases) - [Commits](Chia-Network/chia_rs@0.2.7...0.2.11) --- updated-dependencies: - dependency-name: chia-rs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.