Theme: used local Bootstrap CSS #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
reviewed
Jul 2, 2017
| @@ -6,8 +6,7 @@ | |||
| <meta name="mobile-web-app-capable" content="yes"> | |||
| <meta name="apple-mobile-web-app-capable" content="yes"> | |||
|
|
|||
| {* Bootstrap 3 CDN *} | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous"> | |||
| <link rel="stylesheet" href="resources/bootstrap.min.css"> | |||
There was a problem hiding this comment.
Could you mention version and link here in comments? Just to store the version.
There was a problem hiding this comment.
Added. The version number is also inside CSS itself.
There was a problem hiding this comment.
Thanks!
I'm aware of that, it's just more clear and accessible right above the file inclusion.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, I am working offline. Using remote CSS is a pain when no connection is available or when I would like to avoid mobile data depleting. :)
Also, it should be quicker. With the remote version it was changing the layout when remote CSS was downloaded and parsed.
The CSS I removed was not used. It looks like some old version that was so different from the
bootstrap.min.css.