Enabling Basic Auth configured at runtime #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWittmann
approved these changes
May 6, 2024
carlesarnal
reviewed
May 8, 2024
| @Dynamic(label = "HTTP basic authentication", description = "When selected, users are permitted to authenticate using HTTP basic authentication (in addition to OAuth).", requires = "apicurio.authn.enabled=true") | ||
| @ConfigProperty(name = "apicurio.authn.basic-client-credentials.enabled", defaultValue = "false") | ||
| @Info(category = "auth", description = "Enable basic auth client credentials", availableSince = "0.1.18-SNAPSHOT", registryAvailableSince = "2.1.0.Final", studioAvailableSince = "1.0.0") | ||
| Supplier<Boolean> fakeBasicAuthEnabled; | ||
| Supplier<Boolean> basicClientCredentialsAuthEnabled; |
carlesarnal
reviewed
May 8, 2024
| public Uni<HttpCredentialTransport> getCredentialTransport(RoutingContext context) { | ||
| var enabledAuth = selectEnabledAuth(); | ||
| if (enabledAuth != null) { | ||
| // TODO: was new HttpCredentialTransport(HttpCredentialTransport.Type.AUTHORIZATION, "bearer"); |
There was a problem hiding this comment.
Should this be changed to honour the configured auth type?
There was a problem hiding this comment.
it is, I just need to remove the TODO comment which is a leftover
There was a problem hiding this comment.
oh right, it's using the credential transport from the enabled auth
carlesarnal
approved these changes
May 8, 2024
carlesarnal
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for visibility, I'll finish up this one at some point next week.