Include generator resources #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 25, 2020 14:27
Apicurito generator resources were left out. This commit included the generator Service, Route, DeploymentConfig and the apicurito ConfigMap. It also does a refactor on where resources are created, cleaning up the controller.
|
@redhatHameed Suggested to include this changes. I will do so in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apicurito generator resources were left out. This commit included the generator Service, Route, DeploymentConfig and the apicurito ConfigMap. It also does a refactor on where resources are created, cleaning up the controller.
chore: remove count of nodes from the Spec.Status (because it is useless)
chore: typo
chore: remove enforcing of images after first time resources are created