Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #104] Allow nested resources with the same name #106

Merged
merged 1 commit into from Mar 15, 2013

Conversation

johanneswuerbach
Copy link
Contributor

This PR allows nested resources to have the same name as the parent and doesn't overwrite their documentation by default. In the current version you have to set a custom resource_id, if the controller names were equal.

@iNecas
Copy link
Member

iNecas commented Mar 15, 2013

Looks promising. However, this change is not useful for all the use-cases (see #77 (comment) for explanation of such a use-case). Making this as a configuration option would be great, letting the user decide the format of the resource identifier. What do you think?

@johanneswuerbach
Copy link
Contributor Author

Sure, I'll update the PR.

@iNecas
Copy link
Member

iNecas commented Mar 15, 2013

Fine, Please add that into into the README.rst as well to keep the documentation up-to-date

@johanneswuerbach
Copy link
Contributor Author

I disabled the controller_paths by default to prevent breaking existing implementations, but I would recommend to enable it by default in a later version, because the default behaviour was quite confusing in the beginning.

@iNecas
Copy link
Member

iNecas commented Mar 15, 2013

Great work! Merging. Next release planned for monday (I'm pushing some new stuff today as well). You're not the first one to pointing this out. I agree on turning this on by default once we turn the version to '0.1.0', it won't take long.

iNecas added a commit that referenced this pull request Mar 15, 2013
[Fixes #104] Allow nested resources with the same name
@iNecas iNecas merged commit 7c187eb into Apipie:master Mar 15, 2013
@johanneswuerbach johanneswuerbach deleted the nested-paths branch June 16, 2013 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants