Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api keyword without specifying the verb/path loads values from routes #194

Closed
wants to merge 8 commits into from

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Jan 28, 2014

No description provided.

@mtparet
Copy link
Contributor

mtparet commented Jan 28, 2014

Nice, thanks for the multiple routes additional feature!

@iNecas
Copy link
Member Author

iNecas commented Jan 28, 2014

I've done more testing on our project, discovered and fixed some issues with more complex nesting of routes (with constraints, scopes etc).

We will probably want to be able to determine the way of processing of the route specs into
the path in documentation:

https://github.com/Pajk/apipie-rails/pull/194/files#diff-c252ba104efd0ecb906ad2edd58ce884R71

as folks might have different preferences on if to include the format, braces for optional params etc.
something like Apipie.configuration.routes_path_formatter = lambda { |spec| spec.gsub(/[()]/, '') }

What do you think?

@mtparet
Copy link
Contributor

mtparet commented Jan 28, 2014

Yes, it would be nice having a configuration setting for the formatter of the route path, to have more flexibility.

@mtparet
Copy link
Contributor

mtparet commented Feb 10, 2014

I added the functionality here ifeelgoods@624cbf3

(I reset my branch on yours #187 )

@komidore64
Copy link
Contributor

does this allow you to still give a description for the route? like:

api :description => "This is the route description to the following controller action."

@mtparet
Copy link
Contributor

mtparet commented Feb 10, 2014

@komidore64 Yes, it should keep all others previous behaviors. (otherwise it means there is a bug)

@mtparet
Copy link
Contributor

mtparet commented Aug 24, 2015

We can close this PR @iNecas

@Pajk
Copy link
Member

Pajk commented Dec 12, 2015

@iNecas Closing this PR as this feature is already in master through @mtparet PR if I understand it correctly:).

@Pajk Pajk closed this Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants